@boorad: are you still looking into BRN? Made some progress on that front

I am… I commented on #49

and did more research today

@pesterhazy: ^^

but have to run now… bbl

I’m looking at why the response or result in node-haste comes back with dependencies: [] instead of dependencies: undefined

and trying to trigger the extractor fun

@boorad: I replied to #49

let's chat about it when you have time

@pesterhazy: I’m here again, for a bit. Do we need to make our own channel, #boot-react-native?

hehe, I think this is find as a place to discuss this

ok, so I haven’t looked at your develop branch - what did you do?

did you see my minimal example?

https://github.com/mjmeintjes/boot-react-native/issues/49#issuecomment-235067415

I this demonstrates what doesn't work: node-haste finds "aurevoir.js" as a dep, but not "goodbye.js"

ah, goog.base gets the full app name

right, so you do the s/goog.require/require/g thing

right

also if I add a console.log to extractRequires.js, it never prints

so the regex is not actually used; instead the packager uses some other way to discover "require"s -- but which?

that’s where my tracing led me.

I got the code to go through extractRequires

it's a mystery 🙂

I really wonder how it can extract it (if you search for "require", there's not other match inside node-haste)

how did you re-route the code?

it wasn’t going to extractor function because in node-haste Module/index.js it checks for dependencies === undefined, but always returns []

I also redid the convoluted inline conditionals to more overt if else stmts, so I could control it

once in extractRequires, you and Matt are correct. There’s no difference between goog.require and require. It gets them all.

the question is, how does it usually do the extraction, if not through the regex?

I’m not sure.

I may have come across another extractor… hold on

the code is crazy hard to read (ES6 is not necessarily an improvement, apparently)

yeah, noticed that myself

JSTransform/worker/inline.js

maybe Resolver/polyfills/require.js

I’ve done the export DEBUG=React… thing, didn’t help too much

btw, I have a master branch with a couple of changes myself...

different direction from your develop branch

cool, where are you heading?

getting react-native and node-haste to talk correctly

not your regex replace thing

getting extractRequires called

your question is correct, how does rn work right now, without our transformer?

what does your little example do with the out-of-the-box transformer in use?

not cljs-rn-transformer.js?

it's the same thing

require gets picked up, goog.require doesn't

so it has nothing to do with the cljs-rn-transformer.js

maybe it actually finds it here? https://github.com/facebook/react-native/blob/bd60d828c5fc9cb066e5f647c87ecd6f70cb63a5/packager/react-packager/src/Resolver/index.js#L194

yeah, cuz our transformer uses the default one, unless it says “Generated by ClojureScript” or something like that

exactly

and even then I think it only touches the source map (but I'm not sure)

getResolvedDependencyPairs ?

so they take their extractor out and put it into a separate lib (node-haste) and then bypass it? WTF?

wonder what calls wrapModule...

yeah but looking at the packager code, I can't make head or tails of it

https://github.com/facebook/react-native/blob/bd60d828c5fc9cb066e5f647c87ecd6f70cb63a5/packager/react-packager/src/Bundler/Bundle.js#L34

that calls wrapModule that goes ahead and does that non-haste requires code

what a shit-show

this is it: https://github.com/facebook/react-native/blob/master/packager/react-packager/src/JSTransformer/worker/inline.js#L33

so the actual code for extracting requires isn't actually in node-haste 🙂

or this? https://github.com/facebook/react-native/blob/master/packager/react-packager/src/JSTransformer/worker/extract-dependencies.js#L38

>>> * Extracts dependencies (module IDs imported with the require function) from * a string containing code. * The function is regular expression based for speed reasons.

^^ I think this is not true.. it actually uses babel to parse the js, not regex 🙂

wait… the extract-dependencies.js is the one that I had seen earlier

https://github.com/boorad/node-haste/blob/master/src/DependencyGraph/ResolutionResponse.js#L91

so that one is where Bundler/Resolver might be calling to haste

constructor of that one sets dependencies to [], which I’ve seen in my tracing

so...

which path does it take? There are plenty of requires parsers in these code bases

so I added console.log here: https://github.com/facebook/react-native/blob/master/packager/react-packager/src/JSTransformer/worker/extract-dependencies.js#L35

and it gets called at the right time, so that must be the place

what’s path?

maybe that’s on non-cljs-generated sources?

xxxxbabel MemberExpression undefined Node {
  type: 'StringLiteral',
  start: 13,
  end: 27,
  loc:
   SourceLocation {
     start: Position { line: 1, column: 13 },
     end: Position { line: 1, column: 27 } },
  extra: { rawValue: './goodbye.js', raw: '\'./goodbye.js\'' },
  value: './goodbye.js' }
xxxxbabel Identifier require Node {
  type: 'StringLiteral',
  start: 38,
  end: 53,
  loc:
   SourceLocation {
     start: Position { line: 2, column: 8 },
     end: Position { line: 2, column: 23 } },
  extra: { rawValue: './aurevoir.js', raw: '\'./aurevoir.js\'' },
  value: './aurevoir.js' }

that's the output of adding

console.log("xxxxbabel", callee.type, callee.name, arg);

"MemberExpression" because it's a .member -- makes sense

so that’s the transform step, using their default transformer

that's callee:

xxxxcallee Node {
  type: 'MemberExpression',
  start: 0,
  end: 12,
  loc:
   SourceLocation {
     start: Position { line: 1, column: 0 },
     end: Position { line: 1, column: 12 } },
  object:
   Node {
     type: 'Identifier',
     start: 0,
     end: 4,
     loc: SourceLocation { start: [Object], end: [Object] },
     name: 'goog' },
  property:
   Node {
     type: 'Identifier',
     start: 5,
     end: 12,
     loc: SourceLocation { start: [Object], end: [Object] },
     name: 'require' },
  computed: false }

basically, goog.require

so we can patch the packager to discover goog.require too

would that help?

I think so

can we do it in .babelrc in any way?

I know nothing whatsoever about babel 😞

we'd need to carry a patch to react-native (unless they merge our patch, which seems unlikely)

I came across a patch that allowed more config in .babelrc, and another one to do transforms first for various reasons

I don’t know anything about babel either

gotta run, back online later tonight

I'm on European time, so will be back online tomorrow

we made some progress I think 🙂

✨ https://github.com/mjmeintjes/boot-react-native/issues/49#issuecomment-235094669