Fork me on GitHub
#cljsrn
<
2016-06-21
>
Macroz07:06:37

@alwx: I tried bumping figwheel to a newer version to fix the console println woes but it seems the luno example doesn't work anymore

Macroz07:06:50

e.g. this simple change doesn't work anymore https://github.com/Macroz/luno-react-native

Macroz07:06:03

I see the index.android.js is now deleted but restoring it also does not work

Macroz07:06:27

has anyone got the figwheel 0.5.4-3 to work yet?

balint08:06:32

guys, can anyone enlighten me about rn's bundling when targeting release? i'm not sure why my images are not included (and thus the application fails when run on my physical android phone) all is well when i am running via figwheel (i'm require'ing the static images), but with prod-build this doesnt seem to work?

savelichalex08:06:54

@balint: react packager work with images in prod

balint08:06:59

when i checked my phone's logs via adb logcat after the app crashed i saw it was complaining about requiring unknown module (and the module was the image path i gave it in my cljs)

Macroz10:06:05

@alwx I resolved my figwheel issues by removing the clean-targets from luno example, I've sent a couple pull requests if you are interested

alwx10:06:29

@macroz thanks very much for your investigation and fixes. will check your pull requests later today

seantempesta10:06:23

@balint: And you’re requiring the images with (js/require “imagepath/imagefile.png”)?

balint11:06:11

@seantempesta: to be exact: (js/require "./images/imagefile.jpg")

seantempesta11:06:44

hmm, not sure then. I haven’t had any problems, but I haven’t tried building for Android

seantempesta11:06:44

are the require statements making it into the production build file?

balint11:06:28

they seem to be present in the index.android.js

balint11:06:51

i found this, will have to investigate if gradle runs this: https://github.com/facebook/react-native/issues/8230

seantempesta11:06:18

well, the react packager should be scanning for those statements and bundling any images

balint11:06:35

yeah, i thought it would work.. will look into the problem a bit more later today

balint11:06:39

thanks tho'

knotschi15:06:26

has anybody an idea why my adb does not have a "reverse" command? I have adb 1.0.31 installed. In react-native and in re-natal docu they say I should run "adb reverse" but this command does not exists and is also not mentioned in the adb documentation ( https://developer.android.com/studio/command-line/adb.html#commandsummary )

knotschi15:06:20

damn, I used the version 1.0.31 that was installed by apt-get and not the current version 1.0.36 which was installed by the android sdk. the android studio documentation tricked me because it is completely out of date....

balint19:06:13

@seantempesta: figured out: somehow react-native bundle generates the assets' names like this: from require("./images/nice.jpg"); it becomes: "projectName/images/nice.jpg" where projectName comes from the package.json name... but why?! (if i adjust my requires in cljs to include the project name, i can start up the app on my android phone)

savelichalex20:06:03

@knotschi: also as I know this work in android 5+

seantempesta23:06:03

@balint: haha. I ask myself why all the time too. Good to hear you figured it out. 🙂