Fork me on GitHub
#cljsjs
<
2018-07-11
>
Hukka11:07:14

Is it a new norm that cljsjs packages won't be providing via the cljsjs namespace, or just an accidental omission? For example https://github.com/cljsjs/packages/commit/c2a1ba6ade80e8be31196716aa0cc5a515e5c4b3#diff-3e9f409c8bd791752004db5bf19a2beaL35 broke old requires.

juhoteperi11:07:49

It is normal for new style packages.

juhoteperi11:07:59

MaterialUI 1 is new package so there shouldn't be lots of old requires around.

juhoteperi11:07:34

It also broke lots of other things because icons are now separate package etc, so I kind of like that old requires broke

Hukka11:07:02

It's not so obvious that it's new, since it still has the same name, even if the source is different

Hukka11:07:15

For example clojars shows it just as a newer version

Hukka11:07:52

But yeah. I'll just have to figure out how to contact the guy who updated cljs-react-material-ui. He updated the deps, without touching the requires 😕

juhoteperi11:07:04

cljs-react-material-ui is neever going to work with material-ui v1

juhoteperi11:07:08

and afaik it is abandoned

juhoteperi11:07:51

Okay that could work

juhoteperi11:07:11

At the same time, you can mention that the "usage" section about "I recommend adding this at the beginning of core file" is wrong

juhoteperi11:07:41

Is is required because reagent ns (https://github.com/stephenway/cljs-material-ui/blob/master/src/cljs_material_ui/reagent.cljs) is broken and doesn't require the cljsjs namespace

juhoteperi11:07:54

and it might not work in new Cljs/Closure-library

juhoteperi11:07:47

I've lately worked on refactoring projects from cljs-react-material-ui to just directly calling material-ui through JS interop because the wrapper is unncessary

juhoteperi11:07:53

but I don't have any public examples yet

Hukka11:07:01

I think I'll have to go the same route