Clojurians Log v2

After upgrading react-leaflet I get the following message:

No such namespace: cljsjs.react-leaflet

Hmh, I made a typo there...

Thanks! Trying 🙂

For some reason there is a leafnet error? java.io.FileNotFoundException: …project/cljsjs/leafnet/development/leaflet.inc.js (No such file or directory) clojure.lang.ExceptionInfo: …project/cljsjs/leafnet/development/leaflet.inc.js (No such file or directory)

That's probably due to cljsjs/leaflet typo, I think I already fixed that one...

I should really add proper validation to Cljsjs packaging scripts...

No big deal, I am happy with the previous version tbh. Is there a way I can fix it?

Leaflet 1.1.0-1 should fix this

Oh right, react-leaflet depends on 1.1.0-0

Ah makes sense 🙂

Works fine now 🙂 (looks like I have some updates to make on my code though - the marker is not displaying anymore)

probably not your doing, it looks like the request to get the image does not go to cloudflare cdn anymore, it tries to hit my local machine instead (after updating the leaflet css link). I will stay on the version I have for now

Do you have this (set! leaflet/Icon.Default.imagePath "//cdnjs.cloudflare.com/ajax/libs/leaflet/1.1.0/images") somewhere?

Works for me

I don't, looks like I need the equivalent of that for ReactLeaflet

( https://github.com/PaulLeCam/react-leaflet/issues/255 )

Hmh, should work with react-leaflet also

Hmm, I'm not using that snippet in another project but icons work there

And that is with react-leaflet

Hmm or perhaps that project only uses custom icons

I am looking into custom icons now as well

Stupid check, but your leaflet in the snippet above is :require [cljsjs.leaflet :as leaflet] right?

(looks like ReactLeaflet has no Icon so I have to make one from leaflet directly)

You can't use cljsjs.leaflet :as leaflet

You either need to use js/L.Icon.Default.imagePath, or migrate to use :global-exports

:require [leaflet :as leaflet] works

Hm if I do :require [leaflet :as leaflet] I get leaflet is not defined. I have to read up on :global-export. I tried (set! js/L.Icon.Default.imagePath "//cdnjs.cloudflare.com/ajax/libs/leaflet/1.1.0/images") - no luck

You need Cljs 1.9.854 for :global-exports

https://clojurescript.org/news/2017-07-30-global-exports

Thanks - I know there has been quite a few nice changes lately 🙂

re - require: https://github.com/cljsjs/packages/tree/master/leaflet this seems to suggest to use :require [cljsjs.leaflet :as leaflet]?

It doesn't suggest to use :as leaflet with the old name

right

Proper documentation for this is still missing

no problem at all 🙂

I updated the web page to mention this a few days ago

very nice 🙂 I have to play a bit with it. Appreciate your help 🙂