Clojurians Log v2

@urbank has joined the channel

hey guys, is momentjs packages incorrectly? https://github.com/cljsjs/packages/blob/master/moment/build.boot

i thought per https://github.com/cljsjs/packages/wiki/Creating-Packages packages were supposed to be cljsjs/<lib-name>/dev or prod or common/<lib-name>.ext or min.inc or inc.js

Not all the packages follow that

Some where packaged before the guide and haven't been updated

In this case it would make sense to fix this, because that includes files like cljsjs/common/locale/en.inc.js which might conflict with other packages

i see.. thanks for confirming i’m not insane or dont know how to read code. took me a while to figure out because almost every other package i looked at did it properly

would love it if someone could help me figure out what i’m doing wrong here trying to package a cljsjs so that its compatible with the new 1.9.854 global-exports Here is the fileset of the packaged files:

├── deps.cljs
└── cljsjs
    └── react-table
        ├── common
        │   └── react-table.ext.js
        ├── development
        │   └── react-table.inc.js
        └── production
            └── react-table.min.inc.js

{:foreign-libs [{:file "cljsjs/react-table/development/react-table.inc.js"
                 :file-min "cljsjs/react-table/production/react-table.min.inc.js"
                 :provides ["react-table"]
                 :requires ["react"]
                 :global-exports {react-table ReactTable}}
                {:file "cljsjs/react-table/development/react-table.inc.js"
                 :file-min "cljsjs/react-table/production/react-table.min.inc.js"
                 :provides ["cljsjs.react-table"]
                 :requires ["cljsjs.react"]}]
 :externs ["cljsjs/react-table/common/react-table.ext.js"]}

(sift :move {#"^react-table\.ext\.js$" "cljsjs/react-table/common/react-table.ext.js"
                 #"^react-table\.inc\.js$" "cljsjs/react-table/development/react-table.inc.js"
                 #"^react-table\.min\.inc.js$" "cljsjs/react-table/production/react-table.min.inc.js"
                 #"^react-table-deps\.cljs$" "deps.cljs"})

#"^react-table-deps\.cljs$" "deps.cljs" this part seems unncessary

the file should already be named deps.cljs

well, i’m storing the file inside my-app/resources/react-table-deps.cljs for now until I make this an independent repo. but that shouldn’t matter, should it?

Ummhh, not sure what your are doing

are using boot-cljs without .cljs.edn file?

That would compile all the .cljs files, which would cause this problem if you have react-table-deps.cljs

Hmm, that’s something. maybe because the react-table-deps.cljs is inside my resources, when i try to compile my app which depends on cljsljs.react-table it’s getting confused?

the file has to be on application fileset, not dependencies

for boot-cljs to compile that