Fork me on GitHub
#cljsjs
<
2016-09-15
>
juhoteperi11:09:38

hmm not sure, maybe not

juhoteperi11:09:46

IIRC only data.json is automatically updated

martinklepsch11:09:48

so which of the glorious scripts in there is it that I need to run? ๐Ÿ˜›

martinklepsch11:09:25

seems to be deploy-update.sh?

juhoteperi11:09:34

deploy-update.sh only updates data.json

juhoteperi11:09:46

build.sh updates everything

juhoteperi11:09:08

update.sh generates new data.json

martinklepsch11:09:20

hah, ok, so I have no idea what that script did, not seeing any commits but it did deploy the site

juhoteperi11:09:29

The header text could use another font?

juhoteperi11:09:15

-apple-system,BlinkMacSystemFont,avenir next,avenir,helvetica,helvetica neue,ubuntu,roboto,noto,segoe ui,arial,sans-serif

juhoteperi11:09:27

I not fan of trying to use "native fonts"

juhoteperi11:09:51

I have no idea what the site looks to you

juhoteperi11:09:06

search highlight doesn't work currently?

martinklepsch11:09:11

show me what it looks like for you

juhoteperi11:09:16

just missing .highlight class

martinklepsch11:09:57

could be worse

martinklepsch11:09:06

I gotta run right now but will be back in a bit

juhoteperi11:09:38

and the highlight could be used with dependency vector also

martinklepsch11:09:50

yeah, I think I accidentally removed that

mikebelanger12:09:54

I actually got tripped up the other day trying to use a cjsjs package because I didnโ€™t realize there were README's on github ๐Ÿ˜› So I like the new UI additions.

mikebelanger12:09:43

For what itโ€™s worth, I like the consolas font too

mikebelanger12:09:36

hey guys I just wanted to add an example to cljsjs/threeโ€™s README.md. The guidelines for a PR kind of imply this isnโ€™t PR-worthy. Is there another way I can modify the README?

juhoteperi14:09:48

@martinklepsch did you check what instructions show for Closure libs? there are a few

martinklepsch14:09:04

did not account for that

martinklepsch14:09:12

I just fixed the highlighting stuff btw

juhoteperi14:09:50

We could parse the deps.cljs and use that to check the usage instructions

juhoteperi14:09:05

Usage instructions could note if the library provides multiple namespaces

juhoteperi14:09:23

and if it provides Closure lib (`:libs` -> "This is a Closure library")

juhoteperi14:09:10

Multiple provided ns -> "cljsjs.airbrake and x additional namespaces"

juhoteperi14:09:28

First one is probably always the "main" ns

juhoteperi14:09:58

and once it is parsed, we could pretty-print it when we show it,

juhoteperi14:09:50

we could also add filter foreign-dep / closure lib!

juhoteperi14:09:11

do you want to implement these or should I?

juhoteperi14:09:23

(btw. argh, why is Slack using 100% cpu)

juhoteperi14:09:15

"Package types: Foreign dep, Closure lib, CommonJS/AMD/ES6 (forthcoming)"

martinklepsch14:09:35

I wont be able to spend more time on this today but maybe tomorrow again

juhoteperi14:09:14

Ok, everything will be read tomorrow ๐Ÿ˜„

martinklepsch14:09:09

how do you mean read tomorrow?

martinklepsch14:09:34

Reason I dropped the custom font btw: it felt like a custom font doesn't add much value.

martinklepsch14:09:05

I'm fine with doing something that's not system as long as it's nothing that needs to be downloaded extra, that makes sense?

flyboarder16:09:59

@martinklepsch: not sure if the link alignment is what was intended

martinklepsch16:09:41

That's as I intended it โ€” what would you suggest alternatively?

flyboarder16:09:53

Nvm then, I was thinking maybe justifying the alignment or spacing it so text aligned vertically with the row above it, but if it's just flowing to the next line its not anything really worth focusing on

martinklepsch16:09:54

given that it's 4 you could split them into columns but I just wanted something flexible that could accomodate changing needs ๐Ÿ™‚ @flyboarder

flyboarder18:09:24

@martinklepsch: just used the site on desktop for the first time, very nice!Much useful changes

martinklepsch18:09:21

@flyboarder cool glad you like it! I'll use that moment to also thank you for your contributions to this project ๐Ÿ‘ ๐Ÿ™‚

flyboarder18:09:51

๐Ÿ˜Š the clojure community has created many great tools, im just glad I can give back

flyboarder18:09:22

Also you solved the one thing im constantly doing on the site, and thats searching it (no more cmd+F) ๐Ÿ‘

martinklepsch18:09:17

@juhoteperi what do you think about changing the usage snippet to

(ns your.namespace
  (:require [cljsjs.airbrake]))

martinklepsch18:09:45

@flyboarder I myself will probably still use cmd-f lol

martinklepsch18:09:13

I think the dots + lack of brackets might be confusing that's why I'm asking

martinklepsch18:09:19

could be wrong ยฏ\(ใƒ„)/ยฏ

juhoteperi18:09:41

ยฏ\(ใƒ„)/ยฏ

martinklepsch18:09:59

@juhoteperi so how much did you dislike using tachyons? ๐Ÿ˜„

juhoteperi18:09:13

I guess users will understand that they shouldn't remove their existing requires

juhoteperi18:09:46

@martinklepsch I wouldn't choose to use it myself ๐Ÿ˜„

martinklepsch18:09:00

we already have a small lag when switching the filters; challenge achieved ๐Ÿ˜„

juhoteperi18:09:53

it's just the dom operations

juhoteperi18:09:41

no lag between all - foreign libs, but lag closure libs -> all/foreign libs as it needs to create ~300 list items

martinklepsch18:09:20

I know it's the DOM ops I'm just joking, I guess it's a good problem to have ๐Ÿ˜›

martinklepsch18:09:53

WE HAVE SO MANY LIBRARIES WE NEED TO OPTIMIZE!!111!1

juhoteperi18:09:54

this is one lib I wouldn't probably rewrite on Cljs

juhoteperi18:09:10

Not that I have yet used it on Cljs

martinklepsch18:09:17

looks pretty cool ๐Ÿ‘

juhoteperi18:09:46

I should probably try it with my autocomplete lib as I've been having problems with cases where it needs to list ~500 results

martinklepsch18:09:45

made a few changes to the nav/deps.cljs rendering, nothing exciting https://cljsjs.github.io/

flyboarder18:09:18

easier to read and more noticeable now

juhoteperi18:09:24

Cool. I was sure there must be some classes for something like that ๐Ÿ˜„

juhoteperi18:09:52

"Show Usage Instructions" text could stay the same when toggled? Likke "Usage instructions v" ""Usage instructions ^"

juhoteperi18:09:11

currently, as the width changes, it will in some cases jump between toggles

juhoteperi18:09:14

like with async

martinklepsch18:09:20

Guess we can make it Usage Instructions and then >>|x

juhoteperi19:09:20

maybe proper css caret?

juhoteperi19:09:46

// Dropdown arrow/caret
.caret {
  display: inline-block;
  width: 0;
  height: 0;
  margin-left: 2px;
  vertical-align: middle;
  border-top:   @caret-width-base dashed;
  border-top:   @caret-width-base solid ~"\9"; // IE8
  border-right: @caret-width-base solid transparent;
  border-left:  @caret-width-base solid transparent;
}

juhoteperi19:09:00

and border-top: 0; border-bottom: @caret-width-base dashed; for reversed caret

juhoteperi21:09:09

Hmh, currently links and code have the same color and links don't even have any hover effect

juhoteperi21:09:18

hover -> underline would be good at least