Fork me on GitHub
#cljsjs
<
2016-06-14
>
eyelidlessness01:06:55

is it acceptable to package/release versions against a specific git commit rather than the library's particular release version? i'd like to use a feature in rrule.js which was merged in january but hasn't yet been released. should i just roll my own, or does cljsjs support releases like this?

flyboarder16:06:02

@eyelidlessness: I wouldnt say it’s supported but you can do it, you can create a release for the next version and tag the build as -alpha0

eyelidlessness16:06:43

interesting. thank you.

flyboarder16:06:00

since it probably wouldnt get merged until the actual release is complete, this is kinda the same as rolling your own

flyboarder16:06:36

@eyelidlessness: if you need help creating an alpha package, there is a firebase PR which has something similar, it’s also a work in progress, we tag the builds -rcX

eyelidlessness16:06:26

i played with updating it, pretty much figured it out. but if it wouldn't get merged it doesn't do me much good πŸ™‚

eyelidlessness16:06:55

thanks for your help

flyboarder16:06:02

@eyelidlessness: no problem, id confirm with @juhoteperi on his opinion for pre-release builds

flyboarder16:06:31

since he manages this all πŸ™‚

juhoteperi16:06:12

It is possible and you can even add the git sha to the version (something like "0.1.0-129n823-0")

juhoteperi16:06:58

I may have rejected some such PR's in the past but with proper version it could be okay

juhoteperi16:06:58

But those could have been against some fork, which I'm still against, but if the commit is in upstream repo it should be okay

juhoteperi16:06:49

I'll write some "rules" down on the wiki

eyelidlessness16:06:04

excellent thank you

eyelidlessness16:06:37

it would definitely be against the upstream repo, not a fork. the change has been in since january, but just hasn't been tagged for a release.

eyelidlessness16:06:51

i've also contacted the author asking for a release, will look out for that as well

juhoteperi16:06:45

I'm hoping that will encourage people to write down if they have updated externs when updating the package version πŸ™‚

juhoteperi16:06:35

We should probably have a issue template also, for package requests and such

juhoteperi16:06:15

I guess in addition to the rules there should be some kind of project statement or something: "Maintainers will review PR's and keep build automation working, new packages and updates are provided by contributors."

eyelidlessness17:06:51

:thumbsup: thanks!

eyelidlessness17:06:11

about to pull it into my project and dump my local packaging. really appreciate it