This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2016-01-18
Channels
- # admin-announcements (90)
- # alda (1)
- # aws (23)
- # beginners (60)
- # boot (217)
- # cljs-dev (20)
- # cljsjs (23)
- # cljsrn (85)
- # clojars (28)
- # clojure (101)
- # clojure-art (1)
- # clojure-berlin (10)
- # clojure-dev (16)
- # clojure-my (2)
- # clojure-russia (194)
- # clojure-sg (7)
- # clojure-ukraine (1)
- # clojured (1)
- # clojurescript (99)
- # clojurex (1)
- # community-development (6)
- # core-matrix (11)
- # cursive (26)
- # datomic (51)
- # euroclojure (30)
- # hoplon (560)
- # jobs (44)
- # ldnclj (34)
- # mount (23)
- # music (3)
- # off-topic (10)
- # om (145)
- # onyx (3)
- # perun (38)
- # portland-or (2)
- # proton (55)
- # re-frame (64)
- # reagent (26)
- # ring-swagger (3)
- # spacemacs (21)
- # sydney (3)
- # yada (1)
Hello, is it possible to expose the language-in parameter for minify deftask? It is exposed in asset-minifier
@rohit: I guess adding another option here and passing it to the minify task might be just what's needed: https://github.com/cljsjs/boot-cljsjs/blob/master/src/cljsjs/boot_cljsjs/packaging.clj#L138
@martinklepsch: I agree
Feel free to take a stab at it but also don't worry if you can't right now
@rohit: ping me if you run into trouble
@martinklepsch: will do. thanks!
@rohit: is the handling of the default value necessary? seems that asset-minifier would just handle it if a falsy value is supplied?
or does key destructuring check if the key exists and uses it even if it's nil? not sure tbh
According to this document, :or
is used to assign a value if the key is missing. http://blog.jayfields.com/2010/07/clojure-destructuring.html
@rohit: you're right
just tested on the repl
maybe an alternative would be to supply empty map if lang
isn't set
but in any case this is good, thanks!
ok, ping me when you have it then I can cut a release
@martinklepsch: i've done that
@martinklepsch: thanks! i'll retract my PR on react-timer-mixin
and just update the usage of minify
task after bumping up boot-cljsjs
sounds good!