Fork me on GitHub
#cljsjs
<
2016-01-13
>
rohit12:01:03

i've converted react-timer-mixin to be used in a browser and I want to contribute it to cljsjs. Whats the best way of doing that given that this won't be from an official package?

martinklepsch12:01:19

@rohit: what did you do for conversion? I assume this couldn't be automated in a way?

rohit12:01:55

@martinklepsch: i used webpack for it

rohit12:01:35

i couldn't find any useage of webpack in cljsjs/packages. so wasn't sure

martinklepsch12:01:24

but I see @juhoteperi is typing and he sure knows simple_smile

juhoteperi12:01:39

nah, was just going to say that there are some packages calling npm

martinklepsch12:01:01

basically I think because we're now building on CircleCI we're a bit more lax about how to build packages

juhoteperi12:01:04

using webpack is probably very similar as calling browserify through npm

martinklepsch12:01:10

so if you need to shell out, shell out simple_smile

juhoteperi12:01:48

Yeah. I just would rather keep Makefiles and shell scripts out of the repo and just call some predefined npm script

rohit12:01:14

@juhoteperi, @martinklepsch: thanks a lot. makes sense. I'll give it a shot.

meow13:01:33

we need to make sure the needs of #C0E66E1H7 are being met by #C0CB40N8K

meow13:01:17

we are looking out for #C0744GXCJ and #C0H28NMAS and #C0E66E1H7 is another valuable resource for the community

meow13:01:26

what should we be doing for you all?

meow13:01:49

cuz, you know - there is the #C0J5T38VB

rohit13:01:26

@juhoteperi, @martinklepsch: i've created a basic boot-task for react-timer-mixin but I can't get the sift task to work. could you please help me? the code is here: https://github.com/ducky427/packages/blob/master/react-timer-mixin/build.boot#L43

martinklepsch13:01:34

@rohit: what are you expecting to happen/whats happening?

rohit13:01:38

i am expecting to move the file react-timer-mixin-0.13.2/bundle.js to cljsjs/react-timer-mixin/development/TimerMixin.inc.js. But the move doesn't happen

martinklepsch13:01:01

do you see `Sifting output files..." printed?

martinklepsch13:01:10

if you put (show :fileset true) before and after can you see a difference?

rohit13:01:05

let me try

rohit13:01:54

hmm ... the file seems to be there when I do that

rohit13:01:17

but when I look at the actual tmp directory, its not there.

rohit13:01:27

maybe I am not doing something correctly

rohit13:01:40

Ah. i figured out my error.

rohit13:01:52

my minify task may be wrong

rohit13:01:50

instead of (minify :in "cljsjs/react-timer-mixin/development/TimerMixin.inc.js" :out "cljsjs/react-timer-mixin/production/TimerMixin.min.inc.js"), I was doing (minify {:in "cljsjs/react-timer-mixin/development/TimerMixin.inc.js" :out "cljsjs/react-timer-mixin/production/TimerMixin.min.inc.js"})

juhoteperi14:01:08

@meow: I don't think #C0E66E1H7 has any special needs

juhoteperi14:01:26

This has been relatively low activity channel

meow14:01:35

I meant the site/system as a whole - hosting and so forth

meow14:01:27

for example, we are working with @tcrawley on getting financial/legal/licensing help and support for clojars and the new chat app

meow14:01:04

so I'm wondering if you guys have similar needs, and maybe clojuredocs does as well, etc.

juhoteperi14:01:27

Currently our hosting needs are well satisfied by GitHub, CI by CircleCI open-source plan etc.

juhoteperi14:01:26

Don't know about legal/licensing stuff, I think it helps that we try to keep external code out of the repo. Though some externs are copied from somewhere...

rohit14:01:11

@martinklepsch: thanks for your help. PR submitted!

martinklepsch14:01:30

@rohit: happy to, nice work. 👍 You could squash if you like but don't worry if not

rohit14:01:48

cool. i'll do that

meow14:01:34

maybe think about ways we could integrate chat with all the great packages you guys support

meow14:01:02

like making it easier to reference, discuss, discover packages that are on cljsjs

meow14:01:30

not putting chat into those packages

martinklepsch14:01:31

@meow: let's not pull everyone into this chat discussion simple_smile

meow14:01:43

fair enough

martinklepsch14:01:13

People that want to participate can join #C0CB40N8K but I feel like pushing people to participate offer input on unbuilt chat apps isn't leading anywhere really

meow14:01:08

I'm more interested in making sure you guys don't have issues like clojars faced recently.

rohit14:01:10

@martinklepsch: i've squashed the commits into one