This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2016-01-06
Channels
- # admin-announcements (266)
- # alda (20)
- # announcements (1)
- # aws (16)
- # beginners (16)
- # boot (288)
- # brevis (7)
- # cljs-dev (40)
- # cljsjs (32)
- # cljsrn (5)
- # clojars (23)
- # clojure (169)
- # clojure-art (2)
- # clojure-czech (3)
- # clojure-finland (1)
- # clojure-italy (3)
- # clojure-norway (1)
- # clojure-russia (88)
- # clojure-sg (3)
- # clojurescript (300)
- # clojurewerkz (8)
- # community-development (14)
- # component (4)
- # core-matrix (1)
- # cursive (9)
- # datavis (26)
- # datomic (44)
- # devcards (3)
- # funcool (1)
- # hoplon (7)
- # jobs (4)
- # ldnclj (11)
- # lein-figwheel (1)
- # nyc (2)
- # off-topic (4)
- # om (149)
- # onyx (1)
- # overtone (1)
- # parinfer (15)
- # proton (3)
- # re-frame (9)
- # reagent (45)
- # yada (2)
I don't think that's about missing extern but just that quill extern file is bad: https://github.com/cljsjs/packages/blob/master/quill/resources/cljsjs/quill/common/quill.ext.js#L1-L2
It should be defined either var Quill = ...
or function Quill
and defining same var or function doesn't make any sense
PR welcome
Doesn't matter really. Jquery and some others seem to use function name
: https://github.com/cljsjs/packages/blob/master/jquery/resources/cljsjs/common/jquery.ext.js#L85
and you're saying that you can’t redefine it? So it should be line 2 with the fixed syntax?
Yeah, Just define the function once with both arguments.
so I should go through all the functions and just do the version with the most params?
Oh right all functions have multiple arities defined.
Yeah each function should be defined just once.
Proper closure way would be to use JSDoc to define different arities, but for our use that's not needed
Parameter names don't matter either
so for this: https://github.com/cljsjs/packages/blob/master/quill/resources/cljsjs/quill/common/quill.ext.js#L16-L20
I don't think parameter number matters even
@juhoteperi: Do I need to increment the Quill version? Or is that something the maintainers do after the PR is accepted?
@blissdev: Please increment the build number (`-0` -> -1
). That way I only need to merge the PR and don't need to make any changes myself.
No problems in your PR
Ah, looks like it could have been formatted better. Anyways, thanks again for your help.
Oh, commit messages. I'm happy if someone follows them but I have better things to worry about than enforcing that