Clojurians
#cljsjs
<
2016-01-06
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

blissdev00:01:24

is normal to see a lot of missing externs warnings on an advanced compilation?

juhoteperi00:01:54

I don't think that's about missing extern but just that quill extern file is bad: https://github.com/cljsjs/packages/blob/master/quill/resources/cljsjs/quill/common/quill.ext.js#L1-L2

juhoteperi00:01:27

It should be defined either var Quill = ... or function Quill and defining same var or function doesn't make any sense

blissdev00:01:02

is either way preferable? or does it depend on the Quill code?

blissdev00:01:36

and you're saying that you can’t redefine it? So it should be line 2 with the fixed syntax?

juhoteperi00:01:57

Yeah, Just define the function once with both arguments.

blissdev00:01:12

so I should go through all the functions and just do the version with the most params?

juhoteperi00:01:42

Oh right all functions have multiple arities defined.

blissdev00:01:02

some are different as well, depending on arity

juhoteperi00:01:06

Yeah each function should be defined just once.

juhoteperi00:01:53

Proper closure way would be to use JSDoc to define different arities, but for our use that's not needed

juhoteperi00:01:08

Parameter names don't matter either

juhoteperi00:01:21

I don't think parameter number matters even

blissdev00:01:28

i would just choose line 19?

blissdev00:01:44

ok, will work on a PR to reflect that

blissdev00:01:56

thanks for your help

blissdev00:01:27

@juhoteperi: Do I need to increment the Quill version? Or is that something the maintainers do after the PR is accepted?

juhoteperi00:01:22

@blissdev: Please increment the build number (`-0` -> -1). That way I only need to merge the PR and don't need to make any changes myself.

blissdev00:01:24

does the package download url remain the same?

blissdev01:01:22

ah sorry about that

juhoteperi01:01:45

No problems in your PR

blissdev01:01:05

Ah, looks like it could have been formatted better. Anyways, thanks again for your help.

juhoteperi01:01:55

Oh, commit messages. I'm happy if someone follows them but I have better things to worry about than enforcing that :simple_smile:

blissdev01:01:05

hehe :simple_smile: