cljs-dev

thheller 2025-05-17T08:56:20.506639Z

the shaded business is causing a bit of trouble in shadow-cljs. There is a bit of Java code referencing stuff by their original name, e.g. https://github.com/thheller/shadow-cljs/blob/master/src/main/com/google/javascript/jscomp/ShadowESModuleRewriter.java#L24-L25. with the unshaded jar that works fine. with the shaded it ends up being .google... which obviously doesn't work anymore and crashes

thheller 2025-05-17T08:58:53.207719Z

I can rewrite all the code to use the shaded versions I guess. maybe thats worth doing to eliminate all future guava conflicts, which have been annoying in the past

dnolen 2025-05-17T12:34:07.974539Z

@thheller hrm yeah that's a bit annoying, but I think it would be better to move to shaded - given all the other changes in this release, maybe now is a good time to sort it out.

thheller 2025-05-17T12:46:22.674329Z

yeah just found a very confusing bug https://clojurians.slack.com/archives/C6N245JGG/p1747384025705949 which boils down to having the closure-compiler and closure-compiler-unshaded both loaded and depending on which comes first it either works or not

thheller 2025-05-17T12:46:38.330699Z

but makes total sense to use the shaded stuff, will adjust later

dnolen 2025-05-17T13:07:19.626279Z

thanks!

dnolen 2025-05-17T13:11:35.093479Z

@alexmiller do you see any problem w/ using gh-pages (our fork of closure-library) to host our own Google Closure Library API docs since they have diverged from Google's? We could link to it from the ClojureScript site.

❤️ 5
dnolen 2025-05-17T13:12:06.796389Z

It would also be nice to get all the Closure Library demos going w/ some basic modern styling

Alex Miller (Clojure team) 2025-05-17T14:06:46.622769Z

Makes sense to me