Clojurians Log v2

cljs mostly doesn't use any annotations. closure I assume is "fine". npm often has annotations where they mean completely different stuff than closure, so was causing errors all over the place

hmm actually no. I only turned them off completely for npm code. cljs/closure still runs with them on

ok - yeah that would be extreme 🙂

so you are putting NPM code through Closure - but is that as separate pass or something where you disable a bunch of things? or did you figure out a way to make it work more consistently?

separate :simple path yes. basically just collects all used npm sources, runs them through :simple together and prepends that to the other output.

ok that makes sense

ok cool, I think these warnings will be super annoying so I'd like to modify GCL and cut a release of our own first

yeah makes sense

good thing you have a test suite for this. I guess I didn't run into this because none of my code uses goog.dom stuff