cljs-dev

dnolen 2024-06-04T18:31:03.641059Z

@lilactown hey do you have a minimal repro for https://clojure.atlassian.net/browse/CLJS-3413 ? I looked at this a bit but it's still not clear to me how this is failing, I have branch where first I verify that normally it works (not in :preloads context - then examining :preloads I don't see how :preloads compilation would cause any change here. maybe @thheller can clarify how the machinery is being skipped?

dnolen 2024-06-04T18:32:05.267849Z

far as I can tell, we will compile a single segment preload (with macros), the ns form will be analyzed, the macro load side effect run, and then later when when get-expander-ns is invoked env should have :require-macros.

dnolen 2024-06-04T18:39:09.384759Z

oh nevermind - I get it now

dnolen 2024-06-04T18:39:23.447019Z

it won't be in the requires for the current namespace

lilactown 2024-06-04T18:39:38.710109Z

I linked a repo above https://github.com/lilactown/macro-repl-bug

👍🏽 1
dnolen 2024-06-04T19:24:45.946339Z

@lilactown ok all previous tests passing, https://github.com/clojure/clojurescript/pull/229 - I still need to convert yours into test case - maybe give this spin and see if it resolves your issue (and doesn't create new ones)

lilactown 2024-06-04T19:36:48.285389Z

I probably won't have time to give it a spin today but I'll try tomorrow morning

dnolen 2024-06-04T19:57:17.878289Z

No rush