@dominicm https://github.com/clojure/clojurescript/pull/215 if the tests pass it would be good for you to give this a try
also I think looking at this https://github.com/aranlucas/react-hook-form-mantine/blob/master/package.json - this PR may fix CLJS-3405 as well
It does appear to work for both, yep!
The problem I had with react-hook-form-mantine was twofold:
1. The use of .mjs extension should probably be handled the same way as .cjs us here: https://github.com/clojure/clojurescript/blob/0da9884836e9f8ba190f3b789adcb6b9b85a669c/src/main/clojure/cljs/foreign/node.clj#L127-L128 (because of https://github.com/aranlucas/react-hook-form-mantine/blob/master/package.json#L23)
2. The resolution only checks the first key that exists: https://github.com/clojure/clojurescript/blob/0da9884836e9f8ba190f3b789adcb6b9b85a669c/src/main/clojure/cljs/foreign/node.clj#L111 But if it's not able to use that key (e.g. because the .mjs tripped it up) then it doesn't try the next key.
Either would solve use of react-hook-form-mantine with package-json resolution set to ["module"] .
@dnolen Just checking, was this an intentional side-effect of your change? https://clojurians.slack.com/archives/CRRJBCX7S/p1695930813733249
Intentional yes
fixing this warning would mean helix would be broken for earlier versions of CLJS, right?