Fork me on GitHub
#cljs-dev
<
2022-06-21
>
dominicm10:06:12

I managed to get it working with an entry point which loads main.js and npm_deps.js. I'll write this up at some point, I have a little more to do yet. Ideally I need to generate this entry point, so that I can statically list all the node modules that are used.

dnolen17:06:12

This sounds similar to what I ended up doing in Krell?

dominicm08:06:25

Ooh, I'll take a look

dnolen14:06:38

@tonsky do you have a test case for https://clojure.atlassian.net/browse/CLJS-3382, it would nice to have a regression catch for this

Niki14:06:47

Let me try again. I had hard time yesterday building an isolated use-case so I tested on Rum

dnolen15:06:50

yeah I had a feeling it wasn't easy - since you found it in Rum I thought maybe you had a more minimal repro

Niki16:06:55

Posted the new patch with tests to the issue

dnolen17:06:47

wow, awesome THAnK YOU!

❤️ 2
borkdude17:06:12

I might have hit this one too but also had trouble reproducing it. Thanks!

dnolen19:06:39

@tonsky try master when you have time - if it appears resolved I can cut release

Niki15:06:52

Confirmed, working again!