This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2022-05-06
Channels
- # announcements (7)
- # aws (8)
- # babashka (9)
- # babashka-sci-dev (11)
- # beginners (37)
- # calva (50)
- # cider (15)
- # clj-kondo (30)
- # clj-otel (3)
- # cljdoc (16)
- # cljs-dev (26)
- # cljsrn (4)
- # clojure (168)
- # clojure-doc (1)
- # clojure-europe (17)
- # clojure-gamedev (4)
- # clojure-nl (3)
- # clojure-norway (1)
- # clojure-spec (17)
- # clojure-uk (16)
- # clojurescript (27)
- # community-development (3)
- # css (3)
- # cursive (9)
- # datomic (25)
- # emacs (1)
- # events (4)
- # fulcro (2)
- # google-cloud (2)
- # graphql (11)
- # gratitude (9)
- # humbleui (16)
- # hyperfiddle (2)
- # jobs (1)
- # london-clojurians (1)
- # lsp (16)
- # malli (2)
- # off-topic (71)
- # pedestal (4)
- # polylith (9)
- # portal (94)
- # reagent (6)
- # reitit (2)
- # releases (1)
- # remote-jobs (2)
- # sci (9)
- # shadow-cljs (49)
- # spacemacs (8)
- # tools-build (2)
- # tools-deps (39)
- # vim (7)
- # xtdb (6)
@alexmiller so ASM was just included into Clojure source tree right (+ package renaming)?
w/ appropriate license mentions etc
@alexmiller hrm, so there might be problem here - not w/ transit because that is internal but w/ vendoring tools.reader
but then any downstream tool that binds those to change the behavior of ClojureScript will be broken
well that seems like something to assess for sure :)
might be more complicated than just shading the names then
@alexmiller it appears for tools.reader we don't depend directly on the types / protocols just vars, based on what @arohner I think we can just erase tools.reader class files?
you're still causing a problem when combined with a different version of tools.reader or transit on the classpath (first version wins)
the "good" options imo are: 1) declare a dependency on the lib or 2) vendor in and rename the lib namespaces so there is no conflict
vendoring and not renaming is the "bad" option (whether source or class)
I've bumped transit and tools.reader in the meantime - I think the shading issue probably needs to stew some more
well 1 was meant to imply also NOT copying the dep into the clojurescript jar, which I think is also done?
@alexmiller all we do is invoke compile and JAR it, nothing else
this is what I meant by erasing / eliding the dep class files, if that seems sufficient to you we can do that
(all of which would be easily doable with tools.build now btw - maybe a future project I'd be happy to help with)