Fork me on GitHub
#cljs-dev
<
2022-04-19
>
thheller18:04:43

just a test for now but given the commit comment looks like they are moving to min java11

thheller18:04:26

not sure how many people still use java8 but that might become a problem then

dnolen18:04:02

hrm, though I guess it is 8 years old, I do think a significant number of users have moved on, though I don't think this is captured in the survey? Maybe @alexmiller knows

Alex Miller (Clojure team)20:04:23

you're asking about jvm version usage?

Alex Miller (Clojure team)20:04:19

this is from 2022 results if that helps ...

👍 1
Alex Miller (Clojure team)20:04:41

(answers are multi-select)

borkdude20:04:14

OTOH, the JVM usage in CLJS is at build time, it's not the same as running with JVM in production

👌 2
tomc20:04:08

https://clojure.atlassian.net/browse/CLJS-2820 describes an issue w/ using cljs.loader in a project that doesn't use :modules. cljs.loader isn't compiled to javascript unless the compiler options include :modules. I have a project that would benefit from being compiled with or without code splitting depending on the deployment environment, and compiling cljs.loader when not using modules is necessary to support that. This requires a couple minor changes to cljs.closure/compile-loader. I'd like to submit a patch for that. Any thoughts/things I should be aware of before submitting that?

dnolen20:04:35

@tomc can't think of anything - go for it

👍 1
tomc21:04:49

I added a patch on https://clojure.atlassian.net/browse/CLJS-2820 and am attempting to follow the directions at https://clojure.org/dev/developing_patches but I don't see the "edit" button in Jira. I'm unsure if I'm just missing it or if I need to be given permission to edit tickets.

Alex Miller (Clojure team)21:04:35

hey Tom, I can help with that

Alex Miller (Clojure team)21:04:24

seems like you've signed the CA, have an account, and are in the right groups

Alex Miller (Clojure team)21:04:37

are you just confused by the terrible jira UI?

😂 1
Alex Miller (Clojure team)21:04:01

to edit you just click blindly anywhere in the description

Alex Miller (Clojure team)21:04:26

then it becomes editable and there are save/cancel buttons at the bottom

tomc21:04:52

Hi Alex, thanks for the help. I'm trying to do the "Mark the ticket as having a patch ready for screening by editing the Patch field" part from the guide on http://clojure.org, but even after clicking into the description area I don't see a heading "Patch" or anything like that. Could be Jira's terrible UI, but I'd hesitate to rule out my own incompetence.

tomc21:04:06

nvm, I found it eventually. Thanks again

Alex Miller (Clojure team)21:04:40

ah, there is a Patch field but it might be buried under "More fields" in the right side bar