Fork me on GitHub

I have at a point where I would like to propose it for inclusion with ClojureScript. I’m expecting that there may be requests to modify it (e.g. changing the namespace to clojure.math, and maybe strip out the Clojure cross compilation), but the functionality is there, and it’s 100% ClojureScript (I showed @dnolen a version that embedded JavaScript, but that’s gone now). What process should I go through to make this request? Just add it as a PR to and go from there? Something else?

🎉 4
👍 1
Drew Verlee05:12:10

thats really, cool, i hadn't even realized that was missing.

Alex Miller (Clojure team)19:12:43

I think it would be good to wait at least until the Clojure version settles, since we are still in the process of removing min/max, moving abs to core, moving namespace etc

👍 1
Alex Miller (Clojure team)19:12:09

but Clojure projects don't take PRs so patches on a jira are better


Should I include tests with the patch? (This looks awkward, because the ClojureScript tests I see are all scripts, while my tests are all done as Clojure code that launches a clojurescript repl)

Alex Miller (Clojure team)19:12:28

I will defer that to David

👍 1