Fork me on GitHub
#cljs-dev
<
2021-10-16
>
thheller15:10:58

@dnolen one thing I found about the goog.module changes is that it doesn't account for goog.module.declareLegacyNamespace() which are still quite common. for example in cljs.core we now get

goog.require('goog.array');
goog.scope(function(){
cljs.core.goog$module$goog$array = goog.module.get('goog.array');
});
although it could still just be accessing things via goog.array normally

dnolen15:10:46

@thheller it doesn’t need to account for it

dnolen16:10:03

We just do it in the new way always

thheller16:10:24

yeah, appears to work just fine either way. :advanced output seems identical, just a little more code in dev

dnolen16:10:12

I thought about but after all the tests advanced compilation

dnolen16:10:12

It doesn’t seem to matter

dnolen16:10:13

So no need to handle checking legacy

dnolen16:10:12

The scope is just satisfy closure trying to prevent human error - but it has no real meaning it gets lowered

thheller16:10:32

why the goog.scope? is closure complaining without that?

dnolen16:10:53

Yes because they don’t want you to import modules at the top level

dnolen16:10:58

It’s silly

lread17:10:29

Heya @dnolen, happy to run cljdoc-analyzer tests against cljs master. It’s been a while since I dabbled, https://clojurescript.org/community/building?

dnolen17:10:44

Maybe you have to run script/bootstrap first?

lread18:10:14

@dnolen ok cool. From clojurescript clone, ran:

script/bootstrap
script/build
Then pointed cljdoc-analyzer’s metagetta module at the built clojurescript. Clojurescript deps look right?:
❯ clojure -Stree
org.clojure/clojure 1.10.3
  . org.clojure/spec.alpha 0.2.194
  . org.clojure/core.specs.alpha 0.2.56
org.clojure/tools.namespace 1.1.0
  . org.clojure/java.classpath 1.0.0
  . org.clojure/tools.reader 1.3.4
org.clojure/clojurescript 1.10.888
  . com.google.javascript/closure-compiler-unshaded v20210808
  . org.clojure/google-closure-library 0.0-20210811-6da97fe1
    . org.clojure/google-closure-library-third-party 0.0-20210811-6da97fe1
  . org.clojure/data.json 0.2.6
  X org.clojure/tools.reader 1.3.3 :older-version
  . com.cognitect/transit-clj 0.8.309
    . com.cognitect/transit-java 0.8.332
      . com.fasterxml.jackson.core/jackson-core 2.8.7
      . org.msgpack/msgpack 0.6.12
        . com.googlecode.json-simple/json-simple 1.1.1
        . org.javassist/javassist 3.18.1-GA
      . commons-codec/commons-codec 1.10
And then ran all cljoc-analyzer tests. All passed.