@dnolen one thing I found about the goog.module changes is that it doesn't account for goog.module.declareLegacyNamespace() which are still quite common. for example in cljs.core we now get

goog.require('goog.array');
goog.scope(function(){
cljs.core.goog$module$goog$array = goog.module.get('goog.array');
});

@thheller it doesn’t need to account for it

We just do it in the new way always

yeah, appears to work just fine either way. :advanced output seems identical, just a little more code in dev

I thought about but after all the tests advanced compilation

It doesn’t seem to matter

So no need to handle checking legacy

The scope is just satisfy closure trying to prevent human error - but it has no real meaning it gets lowered

why the goog.scope? is closure complaining without that?

ah 😛

Yes because they don’t want you to import modules at the top level

It’s silly

Heya @dnolen, happy to run cljdoc-analyzer tests against cljs master. It’s been a while since I dabbled, https://clojurescript.org/community/building?

Maybe you have to run script/bootstrap first?

@dnolen ok cool. From clojurescript clone, ran:

script/bootstrap
script/build

❯ clojure -Stree
org.clojure/clojure 1.10.3
  . org.clojure/spec.alpha 0.2.194
  . org.clojure/core.specs.alpha 0.2.56
org.clojure/tools.namespace 1.1.0
  . org.clojure/java.classpath 1.0.0
  . org.clojure/tools.reader 1.3.4
org.clojure/clojurescript 1.10.888
  . com.google.javascript/closure-compiler-unshaded v20210808
  . org.clojure/google-closure-library 0.0-20210811-6da97fe1
    . org.clojure/google-closure-library-third-party 0.0-20210811-6da97fe1
  . org.clojure/data.json 0.2.6
  X org.clojure/tools.reader 1.3.3 :older-version
  . com.cognitect/transit-clj 0.8.309
    . com.cognitect/transit-java 0.8.332
      . com.fasterxml.jackson.core/jackson-core 2.8.7
      . org.msgpack/msgpack 0.6.12
        . com.googlecode.json-simple/json-simple 1.1.1
        . org.javassist/javassist 3.18.1-GA
      . commons-codec/commons-codec 1.10

Great!