Fork me on GitHub
#cljs-dev
<
2021-06-02
>
thheller06:06:57

@lee just for completeness this always fails right?

(ns repro.will-fail
  {:foo #uknown-tagged-literal {}})

thheller06:06:30

so the bug has always been there, just surfaced through the extended ns changes?

lread12:06:09

@thheller thanks for asking. Yes, I think you make an interesting point: https://github.com/cljdoc/cljdoc-analyzer/issues/32 by binding a *default-data-reader-fn* while https://github.com/cljdoc/cljdoc-analyzer/blob/94dbc419bcebdcbdf8ecab839eaa6e037ed9bed4/modules/metagetta/src/cljdoc_analyzer/metagetta/clojurescript.clj#L126-L133 - but it apparently does not handle the case of an unknown tagged literal within a ns form as this binding is not active when calling parse-ns.

🙈 3