Fork me on GitHub
#cljs-dev
<
2021-05-21
>
henryw37409:05:05

quiz: how many java.util.Date instances are created by running clj --main cljs.main -e "(println (.getUTCDay #inst\"2021-05-21T05:36:47.102-00:00\"))" ? Answer in thread

henryw37409:05:46

I expected it to be 0, but it's actually 2. the emitted js is like new Date(123343...) , rather than being e.g. cljs.core.instant("2021-05-21T05:36:47.102-00:00") ... and I guess it's done this way as an optimization

henryw37409:05:41

@dnolen the tests are passing with the current patch attached to https://clojure.atlassian.net/browse/CLJS-3294 and I've included a write-up of how custom data-readers work (which is different from in-built data-readers). If you think that looks ok I'll add some tests

dnolen13:05:48

@henryw374 thanks I don't think we should risk this one in this cycle - but can consider for the next one

👍 2
dnolen13:05:03

there's enough fiddling here to be concerned about unexpected breakage

dnolen13:05:17

@mfikes I think we should start prepping for next release

👍 2
dnolen16:05:59

building 1.10.866 now