Fork me on GitHub
#cljs-dev
<
2021-05-19
>
dnolen15:05:04

@henryw374 look at deps.edn for running the tests - however if this is the same patch as the one in your fork there are failing tests I think?

henryw37415:05:35

yes there are some failing tests. I can look at those. but it would be good to get some idea I'm headed in the right direction here. I mean it seems to work for the compilation scenarios I know of, but I've had to move the code that reads data_readers.cljc... put it in the analyzer ns for now.

henryw37415:05:57

^^^ @dnolen I meant to send that reply to main channel

dnolen15:05:19

a pretty interesting bit of code for the compiler hackers

dnolen15:05:31

@mfikes ^ would like to see what Canary says about this

dnolen15:05:52

@henryw374 oddly I can't preview the patch in JIRA

dnolen15:05:00

perhaps there's a formatting problem?

dnolen15:05:12

there's just something wrong w/ it - nothing in there for me

henryw37415:05:01

ok weird. I'll have a look...

henryw37416:05:12

@dnolen I've replaced that patch with a new one .. which now has some changes in it ;-)

mfikes16:05:42

@dnolen Looks like other cases might be cropping up. I'll see if I can write new ticket(s) as needed to cover them. https://travis-ci.org/github/mfikes/coal-mine/builds/771684236

dnolen16:05:15

@mfikes I'm a Travis newb - how do I see what's failing?

mfikes16:05:25

@dnolen That particular job is split across 5 "parts", and 2 of them are failing ^

mfikes16:05:40

Click on a failing one and then scroll down and you will see the output

dnolen16:05:39

@mfikes out of curiosity what are these? 4clojure problems? 🙂

mfikes16:05:07

Yes. It is a source of diverse code for which we know the expected behavior of.

dnolen18:05:52

ok wasn't really related to my fixes which did address the problem

dnolen18:05:24

rather we've never done generic walking and we were missing the :children key on some binding AST nodes

dnolen18:05:46

so this fixes a bug, and now we have a decent test case that checks that generic walking works

dnolen19:05:45

@mfikes is the next build kicked off?

mfikes19:05:33

@dnolen I'll kick one off (normally they are run at night but it is easy enough to manually kick one off)

dnolen19:05:41

@mfikes already looking promising

dnolen19:05:54

the two that failed before now succeed