This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2021-05-19
Channels
- # aleph (11)
- # announcements (1)
- # babashka (9)
- # beginners (90)
- # calva (6)
- # clj-kondo (24)
- # cljs-dev (26)
- # clojure (92)
- # clojure-europe (48)
- # clojure-nl (1)
- # clojure-spec (4)
- # clojure-sweden (2)
- # clojure-uk (41)
- # clojurescript (60)
- # code-reviews (1)
- # conjure (6)
- # core-logic (3)
- # datascript (1)
- # datomic (3)
- # deps-new (1)
- # depstar (4)
- # dirac (3)
- # emacs (8)
- # fulcro (1)
- # helix (27)
- # introduce-yourself (2)
- # jobs (1)
- # off-topic (4)
- # pathom (2)
- # polylith (8)
- # re-frame (3)
- # remote-jobs (1)
- # shadow-cljs (5)
- # spacemacs (2)
- # tools-deps (22)
- # vim (3)
- # xtdb (27)
@henryw374 look at deps.edn for running the tests - however if this is the same patch as the one in your fork there are failing tests I think?
yes there are some failing tests. I can look at those. but it would be good to get some idea I'm headed in the right direction here. I mean it seems to work for the compilation scenarios I know of, but I've had to move the code that reads data_readers.cljc... put it in the analyzer ns for now.
a relatively straight forward fix https://github.com/clojure/clojurescript/commit/15f330f31a57ef7586b37a81d539f67f2a66b168
@henryw374 oddly I can't preview the patch in JIRA
@dnolen I've replaced that patch with a new one .. which now has some changes in it ;-)
@dnolen Looks like other cases might be cropping up. I'll see if I can write new ticket(s) as needed to cover them. https://travis-ci.org/github/mfikes/coal-mine/builds/771684236
rather we've never done generic walking and we were missing the :children
key on some binding AST nodes
so this fixes a bug, and now we have a decent test case that checks that generic walking works