Fork me on GitHub
#cljs-dev
<
2021-05-17
>
dnolen12:05:49

@lee thanks for the headsup - yeah, closed those

👍 3
dnolen12:05:31

@henryw374 open to that, add the patch to the issue

henryw37415:05:36

Cool. The patch I've done doesn't fully work yet. I'll see if I can get it ready, then attach

henryw37415:05:36

Cool. The patch I've done doesn't fully work yet. I'll see if I can get it ready, then attach

dnolen23:05:14

@mfikes thanks! interesting no other tests failed that look like this

mfikes23:05:33

Coal mine found a handful...

dnolen23:05:45

all the same and only with or?

mfikes23:05:24

Actually, I hadn't surveyed across all of them to see if there are any distinct things outside of the gensym issue... let me take a peek.

dnolen23:05:05

all seem to involve or

mfikes23:05:15

They all look like and and or gensym failures that all fall into the same "category"

dnolen23:05:42

can you include an and repro in the issue?

dnolen23:05:49

would be a good unit test

mfikes23:05:00

Yeah, I'll make a minimal from that one I just linked...

dnolen23:05:52

@mfikes hrm it appears these all involve loop?

mfikes23:05:10

The and one I'm making a minimal for involves a for it appears.

mfikes23:05:35

((fn [s] (for [e (tree-seq sequential? seq s) :when (and (sequential? e) (every? (fn [x] (not (sequential? x))) e))] e)) [[1 2] [[3 4] [[[[5 6]]]]]])

mfikes23:05:46

^ Trying to make that one a little smaller

dnolen23:05:55

ah they are all similar