Fork me on GitHub
#cljs-dev
<
2021-03-30
>
kommen08:03:10

anything we can help with getting the clojurescript release out of the door?

thheller08:03:00

even a pre-release would definitely help with testing stuff. I don't use deps.edn anywhere so depending on master is kinda difficult.

borkdude08:03:32

@thheller do you use lein?

thheller08:03:37

yes, and/or just shadow-cljs.edn

thheller08:03:47

I do have a local CLJS lein install'd version I used for testing but thats "dangerous" 😛

thheller08:03:12

almost made a shadow-cljs release with the newer closure-compiler version as a dependency which would have broken everyone that wasn't on that lein install'd CLJS version 😉

borkdude08:03:17

@thheller does shadow come with tools.deps built in?

thheller08:03:40

no. well support is built-in but it doesn't use it internally. uses the older pomegranate lib by default, might switch when tools.deps gets out of alpha

borkdude08:03:38

@thheller I see. babashka does come with support built-in, using deps.clj: https://github.com/borkdude/deps.clj a port of the Clojure bash stuff to Clojure itself ;)

borkdude08:03:05

it's now being used in Calva to provide a "getting started REPL" when people only have java installed

borkdude09:03:12

anyway, sorry for being off topic, just curious how shadow did it

thheller09:03:13

yeah I just publish a separate uberjar'd small tool that handles the dependency downloading and classpath construction https://github.com/thheller/shadow-cljs/blob/master/packages/shadow-cljs-jar/src/shadow/cljs/npm/deps.clj

thheller09:03:50

by default that is used but there are settings to use clojure or lein instead

dnolen11:03:35

@kommen nah, it's ready to go - we just need to put together release notes and a post

dnolen11:03:46

I can do the change docs / tagging today

bananadance 18
dnolen16:03:16

building 1.10.844 now

dnolen16:03:34

@mfikes let me know if you want me to take a pass at the release notes - it's mostly about calling out the Closure breakage and some small enhancements

mfikes16:03:51

@dnolen Yes, I'll make a pass at the release notes. Maybe I can do that today after work hours.

Alex Miller (Clojure team)17:03:33

let me know when you need the site built

dnolen17:03:22

1.10.884 should be available if people want to test

kommen18:03:27

bumped nextjournal from 3fdaabed to 1.10.844 and ran into a bunch of errors regarding tools.reader:

Error in phase :compile-syntax-check
Exception: namespace 'clojure.tools.reader.edn' not found
we did have an explicit top level dependency on tools reader, which was a bit outdated, bumping this to the latest 1.3.4 made the errors go away

kommen19:03:15

probably related to the new way building the clojurescript uberjar?