This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2020-08-05
Channels
- # all-the-channels (1)
- # announcements (3)
- # asami (13)
- # beginners (227)
- # calva (2)
- # chlorine-clover (8)
- # cider (7)
- # clj-kondo (4)
- # cljs-dev (21)
- # cljsrn (8)
- # clojure (64)
- # clojure-europe (39)
- # clojure-france (2)
- # clojure-italy (3)
- # clojure-losangeles (1)
- # clojure-nl (20)
- # clojure-uk (8)
- # clojurescript (24)
- # conjure (12)
- # datalog (9)
- # datomic (24)
- # emacs (8)
- # figwheel-main (1)
- # fulcro (15)
- # jobs-discuss (1)
- # malli (5)
- # meander (3)
- # off-topic (26)
- # re-frame (15)
- # reagent (10)
- # reitit (1)
- # reveal (1)
- # sci (15)
- # shadow-cljs (25)
- # spacemacs (7)
- # sql (3)
- # xtdb (1)
commit 42bcb07b8bf23d57f98e4617e4c4c93347f09715
Author: dnolen <[email protected]>
Date: Sat Jun 6 12:35:05 2020 -0400
compute-npm-deps needs to check for :npm-deps true case
diff --git a/src/main/clojure/cljs/closure.clj b/src/main/clojure/cljs/closure.clj
index b5a0d1c0..12df2f61 100644
--- a/src/main/clojure/cljs/closure.clj
+++ b/src/main/clojure/cljs/closure.clj
@@ -2437,7 +2437,7 @@
(reduce
(fn [m [dep v]]
(cond-> m
- (not (contains? npm-deps dep))
+ (and (map? npm-deps) (not (contains? npm-deps dep)))
(assoc dep (if (coll? v)
(last (sort v))
v))))
This seems to have broken clj -m cljs.main --install-deps
@alexmiller I notice that we only have a low resolution logo for the ClojureScript site instead serving a higher one for retina displays
you mean icon or on the site?
if you want to file an issue and assign it to me I can look at it, probably won't be for a bit
certainly fixable. I did change it not too long ago I think b/c it was huge, but surely there is a happy medium :)
yeah, that was part of it
it wasn't sized
but I can make that better