Fork me on GitHub
#cljs-dev
<
2020-08-05
>
plexus13:08:10

commit 42bcb07b8bf23d57f98e4617e4c4c93347f09715
Author: dnolen <[email protected]>
Date:   Sat Jun 6 12:35:05 2020 -0400

    compute-npm-deps needs to check for :npm-deps true case

diff --git a/src/main/clojure/cljs/closure.clj b/src/main/clojure/cljs/closure.clj
index b5a0d1c0..12df2f61 100644
--- a/src/main/clojure/cljs/closure.clj
+++ b/src/main/clojure/cljs/closure.clj
@@ -2437,7 +2437,7 @@
      (reduce
        (fn [m [dep v]]
          (cond-> m
-           (not (contains? npm-deps dep))
+           (and (map? npm-deps) (not (contains? npm-deps dep)))
            (assoc dep (if (coll? v)
                         (last (sort v))
                         v))))
This seems to have broken clj -m cljs.main --install-deps

dnolen20:08:28

@plexus I've been using master and I haven't had any problems

dnolen20:08:39

can you be more specific?

dnolen20:08:28

@alexmiller I notice that we only have a low resolution logo for the ClojureScript site instead serving a higher one for retina displays

alexmiller20:08:04

you mean icon or on the site?

alexmiller20:08:07

if you want to file an issue and assign it to me I can look at it, probably won't be for a bit

dnolen20:08:34

the logo on the site

dnolen20:08:59

Clojure one looks like it has a higher resolution one

alexmiller20:08:30

certainly fixable. I did change it not too long ago I think b/c it was huge, but surely there is a happy medium :)

dnolen20:08:44

huh that's probably it 🙂

dnolen20:08:54

also probably why it was flashing

alexmiller20:08:02

yeah, that was part of it

alexmiller20:08:08

it wasn't sized

dnolen20:08:13

ok I assigned it to you

alexmiller20:08:15

but I can make that better

dnolen21:08:45

@thheller merged CLJS-3200 patch

mfikes21:08:45

Ahh cool. I got a CI failure notification for the above off on my own "CI fork" as a result of the new GitHub actions. Looks like the main repo is also showing the same.

thheller22:08:22

weird failure

dnolen23:08:08

yeap, might be JSC related, going to revert for now and look into it later