Fork me on GitHub
#cljs-dev
<
2020-05-13
>
bhauman15:05:59

hmmm do :closure-defines work for the new :bundle target?

bhauman15:05:11

@dnolen just confirmed that CLOSURE_UNCOMPILED_DEFINES and CLOSURE_NO_DEPS don’t make it through the bundler properly, they probably need to be exported to the global window object

bhauman15:05:55

could append window.CLOSURE_UNCOMPILED_DEFINES = CLOSURE_UNCOMPILED_DEFINES; at the end of the boot script after the window.require override

dnolen16:05:36

What optimizations are we talking about?

dnolen16:05:03

Oh I’m assuming :none I guess

bhauman16:05:14

yeah :none

dnolen16:05:07

@bhauman fixed in master, give it a try

bhauman16:05:14

thanks man

bhauman16:05:08

yeah that should do it

dnolen16:05:44

@bhauman let me know when you have something that appears to work - happy to cut an official bug fix release just so that Figwheel has something to align with

bhauman16:05:00

will let you know in a few minutes

dnolen16:05:13

if there's any other bugs that could use fixing for such a release let me know

bhauman16:05:51

@dnolen that did it for me, figwheel-main is now working

dnolen16:05:22

@bhauman and lein-figwheel already all good too?

bhauman16:05:49

its didn’t use closure defines 🙂

bhauman16:05:26

@dnolen actually wait a few,

bhauman16:05:35

I have a test suite I should run

dnolen16:05:45

yeah I'll wait, no rush

dnolen16:05:24

might be good to see if people want to kick it too with a CLJS git-dep

dnolen16:05:48

I think maybe should just wait till Friday to let the feedback roll in

lauri19:05:00

A few docsctrings are placed after the binding form in the clojurescript source. There are also some typos: https://github.com/laurio/clojurescript/pull/1/files Would you be interested in opening a Jira issue so i can submit a patch?

dnolen19:05:47

@lauri yes thanks! have you submitted your CA?

lauri23:05:49

@dnolen I have submitted my CA (have done few contributions in 2016).

dnolen23:05:47

@lauri cool submit a patch!

👍 4
lauri23:05:15

Will do it in the morning! Can I create an issue in Jira myself - couldn’t find this option there at the moment.

lauri23:05:14

Sorry, now I found this button - will create the issue.

bhauman21:05:25

@dnolen its all working. It would be nice to have a release sooner than later, as I’d like to have this milestone achieved 🙂

👍 4
dnolen23:05:45

@bhauman 1.10.764 should be going out soon

👍 12