Fork me on GitHub
#cljs-dev
<
2020-05-11
>
dnolen13:05:52

@bhauman hrm a bunch of users have already gone through that I'm pretty sure it's not redundant

dnolen13:05:06

I also went through it via copy paste

bhauman16:05:29

@dnolen no really it outputs it to out/out/main.js

bhauman16:05:36

the example still works

bhauman16:05:54

but it works in a less confusing manner if you get rid of one ot the out dirs

dnolen16:05:13

ah k

👍 4
bhauman16:05:17

otherwise folks are left thinking its necessary

bhauman16:05:04

btw the :bundle target is fantastic

💯 4
dnolen16:05:33

@bhauman yeah I'm assuming making Figwheel work w/ it is pretty easy-going

dnolen16:05:00

@alexmiller website could use bump

bhauman16:05:05

lein-figwheel was tough getting around the closure changes

bhauman16:05:28

but after that pretty simple, I’m about to deploy lein-figwheel

dnolen16:05:42

@bhauman ah right yeah, the Closure changes were painful

bhauman16:05:07

figwheel-main isn’t done yet, all in all its been some hours though 🙂

thheller21:05:29

@alexmiller there seems to be a problem in the latest core.async release.

------ WARNING #1 - :undeclared-var --------------------------------------------
 Resource: cljs/core/async.cljs:396:15
--------------------------------------------------------------------------------
 393 |   but can be determined by the close? parameter.
 394 |
 395 |   Returns a channel which will close after the items are copied."
 396 |   ([ch coll] (onto-chan ch coll true))
---------------------^----------------------------------------------------------
 Use of undeclared Var cljs.core.async/onto-chan
--------------------------------------------------------------------------------
 397 |   ([ch coll close?]
 398 |      (go-loop [vs (seq coll)]
 399 |               (if (and vs (>! ch (first vs)))
 400 |                 (recur (next vs))
--------------------------------------------------------------------------------

thheller21:05:53

I think thats onto-chan! now?

Alex Miller (Clojure team)22:05:58

onto-chan should still exist, just deprecated

Alex Miller (Clojure team)22:05:17

ah, that is a bug there though

darwin22:05:03

alex: just curious, anyone reported compiler stack overflow after upgrading to 1.1.587 (from 1.0.567)?

darwin22:05:56

I had this issue but didn’t have time to track it down or write a proper ticket, unfortunately travis logs are gone now, downgraded instead: https://github.com/binaryage/dirac/commit/2a47dcce1f9b93e16566f95cfa642ddef3b38511

darwin22:05:37

it is probably on my side, will have to dive deeper, the stack trace looks like this: https://travis-ci.org/github/binaryage/dirac/builds/675503493#L571

Alex Miller (Clojure team)22:05:51

seems like it would be good to capture that for David or someone to look at

Alex Miller (Clojure team)22:05:17

@thheller core.async 1.2.603 is on its way, will probably be available in ~15 min

👍 8
darwin22:05:21

since it affects only my test code, I have a hunch that this hacky code could be causing it: https://github.com/binaryage/dirac/blob/master/src/automation/dirac/automation.clj#L27-L37 something in new core.async could affect it