Fork me on GitHub
#cljs-dev
<
2020-05-07
>
dnolen01:05:40

there is a Windows CI, thought it doesn't mean this would appear

dnolen01:05:55

minimal repo w/ just ClojureScript would be great

Oliver George10:05:07

So repeatable but not new since it fails on 1.10.597 and 1.10.758. I can get it to consistently fail with :whitespace and :simple optimisations. Dev repl and compile, and :advanced optimisations is fine.

Oliver George10:05:20

I'll raise an issue

thheller11:05:25

looks somewhat similar?

Oliver George11:05:30

Yep seems the same. Hmm, perhaps I should close as a DUP.

Oliver George11:05:17

Perhaps things have evolved a little since then :advanced seems to work. (Or my example was too simple - I’ll check this... still works with more complex example under :advanced)

Oliver George11:05:27

Thanks for the link.

thheller11:05:17

np, I vaguely remembered seeing java.nio.file.InvalidPathException: Illegal char <:> before somewhere 😛 but can't remember what I did in shadow-cljs to fix it

Oliver George11:05:55

Yeah, I see your comments there. Do you still have the workaround in place?

thheller11:05:59

I think somewhere paths must be normalized so it doesn't write windows paths into JS output

thheller11:05:32

yeah my hack is still around but was fixing a different issue with [synthetic:1] sources (which the closure compiler sometimes adds itself)

thheller11:05:13

never checked if thats still needed though

Roman Liutikov12:05:52

Bug?

(into (transient []) [1 2 3]) ;; Error: No protocol method ICollection.-conj defined for type cljs.core/TransientVector: [object Object]
(implements? IEditableCollection (transient [])) ;; false

😱 4
Alex Miller (Clojure team)12:05:46

there's a similar ticket in clj I think

Alex Miller (Clojure team)13:05:38

actually, I am misconnecting, although there are some old issue with the hierarchy for transient colls

Alex Miller (Clojure team)13:05:50

I'm not sure how closely cljs matches clj in this area

dnolen13:05:44

@roman01la not a bug that doesn't work in Clojure either

dnolen13:05:05

in general please try it first in Clojure 🙂

dnolen13:05:08

moving that one to blocker as well as some other old path bugs

dnolen13:05:28

feel free to chime in on other old ugly bugs that you believe should be fixed up for the next release

dnolen13:05:49

feature-wise the only thing I'll be looking at is the ns form stuff

Roman Liutikov13:05:25

@dnolen Interesting, but PersistentVector does implement IEditableCollection, how's that (implements? IEditableCollection (transient [])) results in false?

Alex Miller (Clojure team)13:05:14

(transient []) is not a PersistentVector

bronsa13:05:04

IEditableCollection means "can be made into a transient"

👍 4
bronsa13:05:20

you're asking if you can (transient (transient []))

Roman Liutikov13:05:05

ah right, thanks!

dnolen13:05:28

@alexmiller website could use a bump

dnolen13:05:47

this is promising looks like Google is aware of the impact for Closure Compiler users

thheller14:05:58

yeah I'm most curious about how they are going to do the namespacing system. I'd expect them to move to regular import/export for the TS sources. not sure if they are going to bother to keep the old namespaces in place since closure can consume import/export just fine

lilactown16:05:05

would it be possible in the future to have GCC consume foreign TS?

lilactown16:05:52

oh that’s literally what the message is about: don’t require GCC users to have to compile TS 🙃

lilactown16:05:12

which is a bit of a bummer; I found myself wanting to write some JS for some lib code, and decided to try out TS. I started thinking about how I would include it in a CLJS lib/app. Atm I guess the best option is to ship the compiled artifacts to NPM

thheller16:05:31

I saw some references to TS in the GCC code. never actually tried it though.

thheller16:05:55

maybe it is already capable of compiling TS code

lilactown16:05:44

I guess there's a TS -> closure project called tsickle

lilactown16:05:32

Maybe I could compile the TS code to closure JS and then ship that in my jar with CLJS code

dnolen16:05:54

@alexmiller hrm the ClojureScript website seems broken?

dnolen16:05:05

when I click on the links I'm getting file downloads now

dnolen16:05:10

anybody else seeing this?

dnolen16:05:26

I see this in Chrome & Safari

lilactown16:05:36

same on chrome

bronsa16:05:42

and on ffox

lilactown16:05:03

“getting started” on the front page works, but the top nav links download a file

Alex Miller (Clojure team)16:05:40

yeah, I'm working on it

Alex Miller (Clojure team)16:05:32

don't experiment with stuff in prod