Fork me on GitHub
#cljs-dev
<
2020-05-06
>
Alex Miller (Clojure team)18:05:27

@dnolen @mfikes I looked at the cljs testing stuff a bit. I think probably the easiest thing is if you could convert that travis build into a docker file, which I could then easily run in jira. the alternative is installing a bunch of stuff on the build box and there are a bunch of reasons why that's non-ideal.

mfikes18:05:29

Seems reasonable to me.

dnolen18:05:46

@alexmiller so the idea is here is just use JIRA support to apply the patch and run tests?

Alex Miller (Clojure team)18:05:14

maybe I misunderstand what you're looking for, so let's step back ...

Alex Miller (Clojure team)18:05:24

I thought you were looking for a way to automatically run all tests on commit

dnolen18:05:48

@alexmiller oh JIRA has a view for that?

dnolen18:05:58

or you just mean run in JIRA

dnolen18:05:03

and use the hook for GitHub - ok

Alex Miller (Clojure team)18:05:25

crap, I said jira before but I meant jenkins

dnolen18:05:41

I was pretty confused

dnolen18:05:01

cool, sounds reasonable to me

Alex Miller (Clojure team)18:05:15

so, is goal to run all tests with each commit or to have a place to test patches with feedback ?

dnolen18:05:31

the first thing is higher priority

dnolen18:05:37

then we know if something is actually releasable

dnolen18:05:50

the later thing would be icing if related

Alex Miller (Clojure team)18:05:52

ok, I think the latter would build on the former anyway

Alex Miller (Clojure team)18:05:23

well, docker-izing the test would be the best path imo as it clarifies the system install requirements

dnolen18:05:56

would it be easy to partition by runtime kinda like how the JVM version stuff works for Clojure?

dnolen18:05:31

Testing V8, Node, JSC seems like a good start - and of course we need Node.js

Oliver George23:05:58

Hi All, I'm seeing compiler errors on windows. Just wondering if that's interesting or known.

Oliver George23:05:04

I had the feeling there were Windows CI tests.

Oliver George23:05:01

If it's worth tracking down I'll do a minimal repro