Fork me on GitHub
#cljs-dev
<
2020-05-04
>
dnolen11:05:18

ok fixed up the new blocker issues that cropped up over the week

dnolen11:05:55

cutting 1.10.756 now

mfikes12:05:57

Cool... https://clojure.atlassian.net/projects/CLJS/issues/CLJS-3245 is a cut-n-dry one we could apply in order to get unit tests running again

dnolen13:05:02

fixed, building 1.10.758

dnolen14:05:37

@alexmiller another vote for just hooking in @mfikes CI stuff into the ClojureScript main repo so I can see if a commit is failing test

dnolen14:05:56

around releases this really like flying blind - manually running everything locally is not practical

dnolen14:05:01

it's too easy to forget something

dnolen14:05:22

other option would be to do it Jenkins but this seems like a fairly large task for you

Alex Miller (Clojure team)15:05:14

would be happy to learn more about what this would mean

Alex Miller (Clojure team)15:05:54

are you talking about tests in the clojurescript build itself or something external?

Alex Miller (Clojure team)15:05:16

I can make a test job to do arbitrary bash whatever

mfikes15:05:13

ClojureScript has TravisCI and AppVeyor "metadata" files in the root of its tree. For TravisCI, it is pretty much just "go in and turn it on", I think.

Alex Miller (Clojure team)15:05:47

it sounds like you want "when there are commits on clojurescript, then run thing and report" and that's not hard structurally, but depends what "thing" requires

Alex Miller (Clojure team)15:05:54

can you point me more precisely?

mfikes15:05:15

Yeah, in Travis, minimally it really is just a switch ^

mfikes15:05:53

Of course, you can mess around with more complicated settings down in there, but fundamentally, it just starts listening to GitHub commits and puts green checkmarks or red Xs in GitHub, and mails people.

Alex Miller (Clojure team)15:05:14

the travis one seems like it could pretty trivially be just a bash script, which I could easily embed in a jenkins job

Alex Miller (Clojure team)15:05:52

I think it can do that connection back to gh too, but I haven't done that part before

Alex Miller (Clojure team)15:05:47

the appveyor one is windows?

Alex Miller (Clojure team)15:05:21

looks like there are jenkins plugins that can actually run travis yml directly

dnolen15:05:37

yes just all of the tests in ClojureScript itself would be great, nothing external

Alex Miller (Clojure team)15:05:14

your last build failed btw, complaining about upload staging rules which seems very strange to me

dnolen15:05:39

"upload staging rules"?

dnolen15:05:56

oh kicked it again

Alex Miller (Clojure team)15:05:26

when you upload a package of artifacts to maven, it applie some staging rules to check that pom has certain attributes, stuff is signed, yada yada

Alex Miller (Clojure team)15:05:42

afaik, nothing should have changed though in what you're making or what the rules are

Alex Miller (Clojure team)15:05:21

well if it fails again, I'll look deeper

dnolen15:05:36

@alexmiller hrm, failed again

Alex Miller (Clojure team)16:05:07

the rule looks like it's failing because that version already exists

Alex Miller (Clojure team)16:05:00

do you need to bump that or something?

dnolen16:05:14

oh hrm, not sure what happened ok, then we're ok - the version number is automatically computed

Alex Miller (Clojure team)16:05:02

looks like it was built and released at 6:15 am today (not sure if that's my time or eastern), then failed in a rebuild at 8:35 am, and just now

Alex Miller (Clojure team)16:05:58

I don't know - I'd double-check that your last changes are in there

Alex Miller (Clojure team)16:05:41

it's a little unclear to me what happened there

Alex Miller (Clojure team)16:05:39

I'll look at the test stuff this afternoon

dnolen21:05:11

@alexmiller huh it appears something did go wrong, I wasn't hallucinating

dnolen21:05:30

758 never appeared under GitHub releases

dnolen21:05:53

so it seems weird that Jenkins said it happened but the tag was never created

Alex Miller (Clojure team)21:05:49

looking at it again it looks like the part that waits for central to release timed out and so the build job failed and wasn't tagged

Alex Miller (Clojure team)21:05:07

but I bet the release did actually happen to maven, just after the timeout

Alex Miller (Clojure team)21:05:40

and then the next build failed because the release was already theree

Alex Miller (Clojure team)21:05:55

so I would touch something so the rev is different and rebuild

Alex Miller (Clojure team)21:05:38

I missed the timeout message when I looked before

dnolen21:05:52

@alexmiller or I could just create the tag myself no?

dnolen21:05:54

(to go avoid going through all the steps when they're really not needed)

dnolen23:05:59

@alexmiller website could use a bump whenever you get a chance