Fork me on GitHub
#cljs-dev
<
2020-04-30
>
danielcompton00:04:14

One of the things we've heard from Clojurists Together members is that they'd like us to do long-term support, not just one-off grants

danielcompton00:04:33

It's a little tricky with our current funding amounts, but it's definitely something we're looking into and thinking more about

lilactown00:04:51

recording this here, I don't have time to own this rn but don't want it to be lost either: • :bundle target currently serves a broken main.js if you haven't created one yourself when following the webpack guide, it ended up confusing @tekacs • it would be nice to specify NODE_ENV and other env vars in the :`bundle-cmd` , getting away with this now by specifying it in the command that calls cljs.main

dominicm10:04:07

https://github.com/clojure/clojurescript/blob/2f8dd2efdc5a2cb5e708bde09f65784669a72627/src/main/clojure/cljs/closure.clj#L2321-L2325 is this message wrong? Shouldn't it mention source-map given that it only applies when source maps are enabled?

dominicm10:04:11

As an extension, is it possible to remove that assertion altogether? When I'm compiling for production I put :output-to in a temporary directory so that it's fresh every time. I see now why this is needed

dnolen13:04:23

@danielcompton right that's what I would expect - I just noted that a very large number of projects apply and only few get it - and you all actually offer much more than most OSS devs could practically expect from GitHub sponsors for three months

dnolen13:04:43

so I think there is a problem of scale that GitHub sponsoring addresses for the day-to-day maintenance aspect of OSS work

dnolen13:04:19

@lilactown I don't really understand the first point - it sounds like @tekacs didn't follow the guide precisely?

dnolen13:04:49

the second point - nothing is going to change about :bundle-cmd - consider it finished 🙂

dnolen13:04:21

all this environment stuff users will need to sort out themselves - however the guide could be more clear about it - and happy to take PR to that effect