Fork me on GitHub
#cljs-dev
<
2020-04-06
>
kommen10:04:53

will try that, thx

kommen15:04:03

@dnolen ran into this issue while building nextjournal with latest master, which I guess is a blocker. unfortunately I don’t think it would be easy to add a test for that, right?

dnolen16:04:11

@kommen ... yeah not so easy to test for

dnolen16:04:56

one idea - puppeteer is pretty solid - might be nice for some community written tests along these lines

kommen17:04:20

mhm. actually, the issue was caught by our own puppeteer tests

dnolen17:04:22

it just feels like a bit of work to setup puppeteer tests for something that we'd normally see before a release

dnolen17:04:44

REPLs often catch this kind of thing, but the module stuff is a bit of an outlier because it's a build feature but needs a browser to test

dnolen17:04:16

still GCL has been changing at a faster pace than in the past so if this keeps happening I'm not against it