Fork me on GitHub
#cljs-dev
<
2020-04-04
>
kommen17:04:01

@dnolen implementing graaljs support via :target-fn showed the need to allow outputting bootstrap files. would a change like this be acceptable? https://github.com/nextjournal/clojurescript/commit/a75b90c1eb67e5130549fda88e4495c5ee9c23b5

dnolen17:04:41

@kommen it's ok, it's a little subtle so maybe a comment in that code would be helpful for later readers

thheller18:04:54

@kommen how do you use the graal stuff? do you use the Java API directly or via ScriptEngine or just a regular command line script?

kommen19:04:27

@thheller I just noticed that since that post we also adopted the a shared Engine api which allows graalvm cache jit compiler state between multiple execution Contexts. will update the post soon

thheller19:04:46

all your CLJS code is basically sync and you just call it from CLJ? or do you have async handling somewhere?

kommen19:04:55

we just do sync stuff with graal and leave the async parts to jvm clojure

didibus20:04:44

WooHoo awesome, GraalJS support for ClojureScript nice!

kommen19:04:42

but not sure how best to separate this out

kommen20:04:29

@mfikes that the 0 arity get-js-index calls through to arity 1 of get-options looks odd. is this intended? https://github.com/clojure/clojurescript/commit/0f6d24669c95966d781f905d168f20bce9105bbe#diff-3f5db04e51ac4262a2042aa4d80010a2R73

mfikes20:04:19

Good catch @kommen, that code is incorrect.

mfikes20:04:39

(It should be calling get-js-index)

mfikes20:04:51

I'll write up a JIRA and take care of it.