Fork me on GitHub
#cljs-dev
<
2020-03-31
>
dnolen16:03:08

this change should make it a bit easier for REPL developers to just focus on the stuff the matters and re-use everything else

dnolen17:03:42

any reason you see for not applying that and cutting a release?

Alex Miller (Clojure team)17:03:08

Nope, I can do it in a little bit if it looks good to you

Alex Miller (Clojure team)17:03:11

There are a bunch of cljs async bugs if you wanted to review any other ones

dnolen17:03:16

I'm happy to got a query for me to look at?

Alex Miller (Clojure team)18:03:49

Away from computer, give me 15

Alex Miller (Clojure team)18:03:06

your query above was a little ambiguous - did you mean https://clojure.atlassian.net/browse/ASYNC-165 ?

dnolen18:03:57

you already merged it

Alex Miller (Clojure team)18:03:56

core.async currently depends on 0.0-2311 which is ... old

Alex Miller (Clojure team)18:03:13

what should that be bumped up to?

dnolen18:03:11

hrm really, project.clj says 1.1.170

Alex Miller (Clojure team)18:03:32

sorry, I was talking pom

Alex Miller (Clojure team)18:03:39

I guess in this case the project is more relevant

Alex Miller (Clojure team)18:03:48

but anyways, that's also old :)

dnolen18:03:38

it doesn't really matter that much to be honest

dnolen18:03:50

at some point I'd like to update the tests to something more modern

dnolen18:03:06

but not high piority, cljsbuild works fine and so does the version of ClojureScript for testing purposes

Alex Miller (Clojure team)18:03:19

do you mind if I bump up to latest?

Alex Miller (Clojure team)18:03:42

this also affects the clojure version in there, and then bumping that leads to (fixed) spec issues in cljs and cljsbuild

Alex Miller (Clojure team)18:03:03

everything seems good on newer versions

Alex Miller (Clojure team)19:03:16

let me know when you hit a stopping point with patches

Alex Miller (Clojure team)19:03:12

I'll update that, and the readme, and do a release

dnolen19:03:13

almost done

dnolen19:03:20

I only looked at things with patches

dnolen19:03:03

@filipematossilva applying your interop patch, sorry for delay

4
Filipe Silva19:03:56

sweet, looking forward to it!

dnolen19:03:19

going to add EXPERIMENTAL to the docstrings so there's some time for feedback

dpsutton19:03:59

thanks for merging my first contribution to core.async!

dnolen19:03:04

@dpsutton thanks for submitting a patch! sorry for the delay

parens 4
Alex Miller (Clojure team)19:03:24

ok, I'll take it from here!