Fork me on GitHub
#cljs-dev
<
2020-03-29
>
dnolen19:03:23

thanks will take a look

mfikes20:03:20

Cool. At this point, I think we have patches queued for all currently known issues.

mfikes20:03:38

(Surrounding the latest changes, of course. 😉 )

dnolen20:03:59

anything else I should look at?

mfikes20:03:16

Yeah, there are 2 or 3 CI ones... just a sec...

dnolen20:03:15

approved those two, go for it

dnolen20:03:20

looking at the first now

dnolen20:03:10

@mfikes ah yeah that's pretty trivial too - pushed what should be fix to master - feel free to resolve if that works for you

dnolen20:03:51

goog.module was really a bad idea - goog.base used to be pretty simple - I see it's kind of complicated mess now

dnolen20:03:31

at first I thought it was a bit clever but the whole runtime transpile thing is a kludge

😱 4