Fork me on GitHub
#cljs-dev
<
2020-01-28
>
juhoteperi20:01:38

I've just added direct dependency to java-protobuf 3.4.0 on projects where I have run nvd, haven't had any problems with that. So that can be a fix if (when) updating Closure compiler isn't that simple.

dnolen20:01:44

yeah that's an ok workaround, but we really are way behind on the Closure Compiler releases - looking into updating to the latest now

🎉 8
dnolen20:01:02

I patched up the goog-define issues in a branch and now looking at what's going wrong w/ module processing

thheller23:01:37

@dnolen FWIW I think you are making the goog-define stuff much more complicated than it needs to be. I patched it in shadow-cljs by just adding :jsdoc meta, no need to go into the compiler for that. (its a function because I alter-var-root the macro var) https://github.com/thheller/shadow-cljs/blob/e77f60936cb5f63ba664212e5aa68b157e2fafc5/src/main/shadow/build/cljs_hacks.cljc#L657-L685

dnolen23:01:43

Yeah could simplify it for sure

dnolen23:01:23

But it’s really just a detail to fixing up the other issues