This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
- # announcements (2)
- # architecture (3)
- # beginners (72)
- # cider (15)
- # cljs-dev (27)
- # clojure (85)
- # clojure-berlin (3)
- # clojure-dev (4)
- # clojure-europe (7)
- # clojure-italy (7)
- # clojure-nl (6)
- # clojure-uk (17)
- # clojurescript (63)
- # clojutre (10)
- # core-async (10)
- # cursive (10)
- # datomic (34)
- # events (4)
- # fulcro (3)
- # funcool (8)
- # incanter (1)
- # jackdaw (1)
- # jobs-discuss (6)
- # joker (4)
- # kaocha (7)
- # leiningen (8)
- # nrepl (6)
- # off-topic (11)
- # reagent (8)
- # shadow-cljs (119)
- # spacemacs (11)
- # sql (11)
- # vim (30)
- # yada (2)
made some enhancements to clj-kondo which utilizes type hints. it found this: > cljs/util.cljc:361:19: error: Expected: integer, received: nil. https://github.com/clojure/clojurescript/blob/a760439b5084937a556712d6ee056e95f4f075c7/src/main/clojure/cljs/util.cljc#L359 that begs the question if the type hint is correct when the value can also be nil.
If the type hint on
^long, I would wonder about the type hint, too, but I can't see a reason for
^Long being incorrect.
Yeah, and there is that whole notion of
^double being type declarations (they are evidently special).
I think they cause the compiler to emit an impl of one of these interfaces: https://github.com/clojure/clojure/blob/master/src/jvm/clojure/lang/IFn.java#L97-L454
If I was setting up running ClojureScript tests for core.rrb-vector, would you recommend I do it using nashorn so that it matches what data.xml is doing, and they can both be fixed if/when it is removed in the future? Or would you recommend I figure out how to set up a different runtime to run on the Hudson build box?
(or look at a different example than data.xml, that already uses a different JS runtime, if you know of such an example)
@andy.fingerhut May be of interest:
https://clojure.atlassian.net/browse/CLJS-3088 (removed Nashorn from ClojureScript's CI)
https://clojure.atlassian.net/browse/CLJS-2927 (a patch to suppress that deprecation warning)
core.rrb-vector supports self-hosted, so if feasible, I'd incorporate self-hosted into its test suite.
Thanks for the links. I don't yet have a good working knowledge of what it means to run self-hosted tests vs. nashorn vs. some other option. My belief is that the http://build.clojure.org automated test results are all run on a machine running Hudson software, not using Travis, true?
Sure, and please don't dive into it unless it sounds like your world of fun, which seems unlikely 🙂
Is your guess that this nashorn warning thing might be "they will actually leave the deprecation warning around until JDK 15, when they actually get around to removing it?"
That's a good question. I'm wondering / speculating if Graal.js is supposed to replace it. Dunno.
If it might be a ways off, I may be a bit lazy and just make core.rrb-vector as much like data.xml as I can, so easier to update them in a common way later.
I was mainly looking for a reaction like "nashorn? Never, ever test with that any more -- it's too ancient to be of any use" vs. not that reaction 🙂
> I'm wondering / speculating if Graal.js is supposed to replace it. That's my understanding.