Fork me on GitHub
#cljs-dev
<
2019-09-14
>
dnolen16:09:02

@mfikes fixed the above issues with the goog var support

mfikes16:09:34

Cool. One outstanding one is https://clojure.atlassian.net/projects/CLJS/issues/CLJS-3168 That might be trivial to fix; I’ll take a look at it.

dnolen16:09:35

oh yeah I can fix that

mfikes16:09:40

I think I like the name :js-fn-var… it matches the notion I had in mind, but couldn’t think of a good name for it. 🙂

mfikes16:09:58

Cool, yeah, probably just a conditional around the use of the externs ns

mfikes16:09:54

There are a couple of other minor issues I noticed. Logging them https://clojure.atlassian.net/browse/CLJS-3169

mfikes16:09:14

No big deal for that one, of course… just capturing anything strange I can find.

mfikes16:09:08

Hrm. I thought I saw parameters missing from doc output on some fns. Maybe that was fixed… will track that down.

dnolen17:09:02

@mfikes thanks, yeah in goog.string those are control characters - need to think about that

mfikes17:09:25

Cool, yeah, there are funky var names like " etc. Maybe the same cruft.

mfikes17:09:25

I’m now thinking the missing parameter name issue was probably me, and they’ve been there all along.