Fork me on GitHub
#cljs-dev
<
2019-07-15
>
borkdude16:07:19

ok, I'll have a look this week. gotta find out when exactly it was deprecated đŸ™‚

borkdude16:07:54

e.g. the replicate docstring was updated to deprecated with this commit: https://github.com/clojure/clojurescript/commit/8d33dd4e55cc87c205bb5c37d0234af6e2132388 24 April 2016. But I bet the function was considered deprecated before that. Maybe I'll just add ^:deprecated instead of :deprecated "1.x.xx"?

Alex Miller (Clojure team)16:07:00

that would make the value true, which seems weird given that :deprecated values are normally strings

andy.fingerhut16:07:21

Given how long ago it was, perhaps just pick the first release version after the commit date, and call it deprecated since then?

borkdude16:07:32

@alexmiller I've seen ^:deprecated before

borkdude16:07:31

The docstring was probably just copied from Clojure. (cc @mfikes)

borkdude16:07:00

but if there are no objections, I'll go with @andy.fingerhut's suggestion and add 1.8.51 there

Alex Miller (Clojure team)17:07:59

I guess if it’s truthy that’s the main thing