Fork me on GitHub
#cljs-dev
<
2019-06-03
>
Filipe Silva16:06:27

Heya, I was trying to reproduce and understand what's happening in https://clojure.atlassian.net/browse/CLJS-2992 It looks like GCC is declaring a local variable that shadows the GCC namespace object, which then causes local assignments to not use the real namespace object I'm unsure of what code was originally generated by https://clojurescript.org/guides/javascript-modules as the steps in that example doesn't seem to work anymore (it throws java.lang.ClassNotFoundException: javax.xml.bind.DatatypeConverter). Does anyone have some pointers for me to continue looking into this?

dnolen16:06:59

@filipematossilva to be clear :npm-deps stuff (which was always of alpha quality) isn't super high priority any more

dnolen16:06:58

I would consider that ticket to be a really advanced one too - you will need to understand the interaction between Closure & ClojureScript pretty well

dnolen16:06:18

that said if you're determined look at cljs.build-api-tests

dnolen16:06:29

I thought we had es6 module tests, maybe we need more

dnolen16:06:57

I'm assuming you're ignoring the versions discussed in the ticket and using the latest

Filipe Silva16:06:26

yes, I am using latest

Filipe Silva16:06:15

to be honest I'm mostly just looking for stuff I can help in within my skillset... if this isn't very relevant I'm happy enough to look at other things

dnolen16:06:16

@filipematossilva I think we have a newbie tickets tag - I would start there

dnolen16:06:41

just get something small in and get used to the process

Filipe Silva16:06:03

ah cool, I see that now

Filipe Silva16:06:08

will take a look, thanks!

mfikes23:06:24

We are coming up on 2 years since checked arrays (https://clojurescript.org/news/2017-07-14-checked-array-access) Maybe it should default to :warn at some point? (I'd guess all of the popular libraries have now been updated.)