Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2019-05-17

Channels

#cljs-dev
<
2019-05-17
>
mfikes12:05:56

Looks like cljs-oops might be failing with the latest commit. See https://travis-ci.org/binaryage/cljs-oops/builds/533652218

mfikes12:05:48

Maybe it is just an overly tight test with this now being goog.global for the relevant tests. (Speculation on my part.)

darwin14:05:09

yeah, you are correct, btw. I’m testing snippets of generated code to match my expectations, so the tests are extremely tight, but advantage is that I get notified when something changes to review it - which is not very often, no big deal, I will update them easily

kommen19:05:19

@mfikes one more thing about turning off js.java-package-globals: output-main-file relies on the globals right now https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/closure.clj#L1672-L1676

thheller20:05:08

@mfikes you got some experience benchmarking the CLJS compiler. do you have something that measures memory use as well?

thheller20:05:39

not actually sure how that would work but maybe you do 🙂

mfikes20:05:31

@thheller No... I vaguely recall something that I think Liutikov did... searching...

thheller20:05:31

hmm would need something for the JVM 🙂

mfikes20:05:32

Oh, sorry are you worried about JVM use?

thheller20:05:45

I guess a profiler would do

mfikes20:05:13

So, all I know is that if you set things to be a fixed size (that's big enough), that tends to be much better than letting it vary.

thheller20:05:52

I'll just try my luck with visualvm

mfikes20:05:55

For these https://github.com/mfikes/cljs-perf I set things to be pretty big given the size of the codebase being compiled

thheller20:05:07

hmm right. I'll see if visualvm or jmc do the trick

thheller23:05:34

@mfikes if you get a chance can you kick of your CI machinery for https://clojure.atlassian.net/browse/CLJS-3077?

👍 4
darwin12:05:07

I’ve just added you as a collaborator to https://github.com/cljs-oss/canary, you can kick canary builds against your fork, see https://github.com/cljs-oss/canary/tree/jobs

thheller23:05:12

new JIRA hype 😉

Alex Miller (Clojure team)23:05:37

Fyi, a number of patches failed to come over in the migration and I am manually fixing those

Alex Miller (Clojure team)23:05:48

There are about 50 cljs tickets affected

thheller23:05:04

@alexmiller is it possible to enable markdown for the new JIRA somehow? so used to writing markdown that I always have to write ticket texts twice to fix it 😛

Alex Miller (Clojure team)00:05:05

Don’t know, far down my list of concerns atm