Fork me on GitHub
#cljs-dev
<
2019-05-02
>
lread01:05:55

ok, thanks @dnolen, I’ll revert that change in my PR, I do find this section a bit vague for a newcomer though. I’ll walk through it tomorrow and see if I can clarify somehow.

dnolen13:05:14

@lee perhaps you can elaborate on what confused you?

lread13:05:22

Sure, be happy to! Here’s the text under Don’t forget: > Besides the tests it’s important to make sure that the Browser REPL hasn’t accidentally been broken. Double-check using the sample found in the repository. Remember, I’m a newbie, so at first reading, I don’t know where or what “the sample” is and I don’t know what I’m supposed to be checking. And I’m also thinking, wait, didn’t I just run REPLyish tests under https://clojurescript.org/community/running-tests#running-clojurescript-cli-tests ?

lread13:05:48

And when I do think I have found what must be the sample here https://github.com/clojure/clojurescript/tree/master/samples/repl the README states: > NOTE: this sample is now out of date. Please refer to the Quick Start

lread13:05:49

So, as a newbie, I don’t have a confidence in what steps I should be taking.

dnolen13:05:23

@lee ah yes that's the culprit

dnolen13:05:36

that bit about the Browser REPL is obsolete

dnolen13:05:04

no need to check the sample anymore since the whole thing is actually built into cljs.main now and is the default REPL

dnolen13:05:20

clj -m cljs.main is all you need now

dnolen13:05:26

from the root of the project

dnolen13:05:13

@lee I don't recall actually if the REPL tests actually use the browser REPL - I would be surprised if they do

dnolen13:05:35

I agree all of that's confusing - does the above clarify?

lread14:05:00

Thanks @dnolen, that helps. I don’t think browser REPL tests are automated, but you can specify browser as the repl-env for ./script/test-cli repl-env which is what I was referring to as “REPLyish tests”.

dnolen14:05:40

@lee if that works, then probably that's what should be recommended

dnolen14:05:03

@lee btw all of this really appreciated 🙂

lread14:05:39

Sounds good. It is my pleasure, really. Thanks for all you do!