Fork me on GitHub
#cljs-dev
<
2019-04-14
>
thheller09:04:23

@dnolen any thoughts on https://dev.clojure.org/jira/browse/CLJS-3071? I'd be happy to provide a patch for that in case you don't object.

thheller10:04:53

I forgot about :fn-invoke-direct which reduces the overhead down to 3-10% but still worth considering IMHO

martinklepsch17:04:02

Hey 🙂 when cljdoc analyzes some libs string requires a la ["react" :as react] cause the analysis to fail because react hasn't been provided to the analyzer. Now libraries that depend on react usually also don't have a way to declare their dependency on React in a way that cljdoc can make use of so I'm wondering if it would be possible to "stub out" any string requires and silently ignore them?

🙏 1
martinklepsch17:04:47

> don't have a way to declare their dependency on React in a way that cljdoc can make use of For context: cljdoc's analysis currently only considers the jar and the pom file. We could probably parse package.json and do some stuff with that but that would require some more work so I'm wondering if there's a shortcut as described above.

dnolen18:04:57

@martinklepsch I think what you need is probably already there

dnolen18:04:09

we need to able to analyze files already w/o following dependencies

dnolen18:04:12

:analyze-deps false

martinklepsch18:04:35

@dnolen thanks! I remember setting *analyze-deps* to true to fix issues with macros and stuff. Is the :analyze-deps option something different?

dnolen20:04:23

they accomplish the same thing

dnolen20:04:38

:analyze-deps is an analysis option yes