Fork me on GitHub
#cljs-dev
<
2019-02-17
>
mfikes00:02:47

Yeah, the docstring claims :context defaults to :expr. Hrm.

mfikes01:02:44

Strictly speaking, fixing the code to default :context to :expr is a breaking change. On the other hand, it is challenging to see how there could be clients relying on it defaulting to :statement. (It seems likely that all callers are explicitly specifying :expr.)

mfikes01:02:40

(Checking the code behavior at the time the docstring was written, it wasn't defaulting to :expr back then, so probably not a regression, but rather an oversight.)

john18:02:31

After a cursory look on github, seemed everything was providing :expr explicitly. But hard to know absolutely

john18:02:04

Maybe :statement should be the default

john18:02:44

What are the situations someone would want to use :statement?

john19:02:24

I guess it's like a -e at the cli, where you don't care about re-using the environment after getting the result