Fork me on GitHub
#cljs-dev
<
2019-02-13
>
dnolen16:02:40

going to do a release today with 3048 and a few minor odds & ends from JIRA - I don't think there's much need for a post etc.

dnolen16:02:28

now would be a good time to test with master - it's just the spec fixes, and I expanded the mime types / encodings for browser REPL to add some more common media types

borkdude16:02:39

oh you already did 🙂

borkdude16:02:48

Tested https://github.com/borkdude/speculative with CLJS master with Node and Planck. All seems good.

borkdude17:02:40

Sanity check:

$ clj -Srepro -Sdeps '{:deps {org.clojure/clojurescript {:git/url "" :sha "c87d61e54fbbeae390e522ba315f0207fb0fed75" org.clojure/test.check {:mvn/version "RELEASE"}}}}' -m cljs.main -re node
cljs.user=> (require '[clojure.spec.alpha :as s])
 (require '[clojure.spec.test.alpha :as stest])
(defn foo [])
nil
cljs.user=> nil
cljs.user=> #'cljs.user/foo
cljs.user=>  (s/fdef foo :args (s/cat))
cljs.user/foo
cljs.user=> (stest/instrument `foo)
[cljs.user/foo]
cljs.user=> (foo)
nil
cljs.user=> (foo 1)
WARNING: Wrong number of args (1) passed to cljs.user/foo at line 1 <cljs repl>
Execution error - invalid arguments to cljs.user/foo at (<cljs repl>:1).
(1) - failed: Extra input
cljs.user=> (stest/check `foo)
Execution error (Error) at (<cljs repl>:1).
Require clojure.test.check and clojure.test.check.properties before calling check.

cljs.user=> (require '[clojure.test.check])
nil
cljs.user=> (stest/check `foo)
Execution error (Error) at (<cljs repl>:1).
Require clojure.test.check and clojure.test.check.properties before calling check.

cljs.user=> (require '[clojure.test.check.properties])
nil
cljs.user=> (stest/check `foo)
[{:spec #object[cljs.spec.alpha.t_cljs$spec$alpha19434], :clojure.spec.test.check/ret {:result true, :pass? true, :num-tests 1000, :time-elapsed-ms 179, :seed 1550077180524}, :sym cljs.user/foo}]

👍 5
dnolen19:02:37

building 1.10.520

thheller22:02:24

@mfikes can you cut a new release for the google closure library? not sure if we can bump the dependency in CLJS but would be useful for testing

thheller22:02:21

they started marking regular releases to npm under google-closure-library as well. maybe we can align the releases somehow

mfikes22:02:56

I don’t have the needed permissions to cut a release for GCL—that may need David. (It is certainly possible to build locally for testing purposes.)

Alex Miller (Clojure team)23:02:42

if it's just pressing the button on the build box, let me know

dnolen23:02:35

building it now