Clojurians
#cljs-dev
<
2019-02-06
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

richiardiandrea19:02:18

question, does expound work with 1.10.516 ? I have a comment in my sources that it does not with 1.10.439

borkdude19:02:45

you should ask the author of expound (@bbrinck)

richiardiandrea19:02:53

well I can definitely try it out (sorry lazy question here :smile:)

bbrinck19:02:23

1.10.439 didn’t work with expound only if you were trying to use expound for macro-expansion or instrumentation

bbrinck19:02:48

I haven’t tried it with 1.10.516, but my guess is that all the recent great work to port over the way errors are handled will fix the issue

bbrinck19:02:31

If you use expound for anything else, both versions should work, please open a bug if 1.10.516 doesn’t work.

richiardiandrea00:02:03

seems like it works with instrumentation, just tried

richiardiandrea19:02:04

yeah I am using it for instrumentation - so will open issues, thanks for the update!

borkdude23:02:22

I noticed I created a duplicate for CLJS-2844 here: https://dev.clojure.org/jira/browse/CLJS-3049 I thought it wasn’t implemented because I did something wrong in the REPL myself (you first have to unstrument something before the undef becomes effective). When looking into the code of CLJS-2844, I noticed that there isn’t special handling of nil here: https://github.com/clojure/clojurescript/blob/master/src/main/cljs/cljs/spec/alpha.cljc#L71 This has the result that after undefining a spec, it’s still present in the result of (stest/checkable-syms). So, I think I’ll rename the issue to address this.