Fork me on GitHub
#cljs-dev
<
2019-01-22
>
isak01:01:55

To solve the - vs _ munging problem, does mapping - to _DASH_ seem reasonable? (Instead of _, like now.) The bug: https://imgur.com/a/6wNv2mZ (I think there is a Jira ticket for this already)

thheller09:01:09

@isak problem is that this would potentially break a lot of applications that rely on calling functions from html. <script>my.app.do_something();</script> would break given that it would be do_DASH_something() now.

5
thheller09:01:13

but there is a precedent for where _DASH_ is useful/required 😉 https://github.com/clojure/clojurescript/commit/4bcc95175e4282d43ed74bf0abd670550fc40140

dnolen14:01:25

@isak expect no change here - not enough value

isak14:01:58

@dnolen What about a compile error? We've gotten bit by this bug many many times in my project, because of differing naming conventions in database vs clojurescript

dnolen15:01:01

@isak warning would be fine, patch is welcome for that

5
dnolen15:01:44

I think this one will be a bit annoying to write - and I really don't think that many people are affected about - so minor priority